tikv: fix infinite panic when GRPC transportReader is broken #18437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild |
Codecov Report
@@ Coverage Diff @@
## master #18437 +/- ##
===========================================
Coverage 79.2752% 79.2752%
===========================================
Files 541 541
Lines 145295 145295
===========================================
Hits 115183 115183
Misses 20823 20823
Partials 9289 9289 |
tiancaiamao
reviewed
Jul 9, 2020
|
LGTM |
|
@tiancaiamao,Thanks for your review. |
lysu
added
the
priority/release-blocker
|
LGTM |
ti-srebot
approved these changes
Jul 14, 2020
coocood
approved these changes
Jul 14, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@lysu merge failed. |
|
/run-all-tests |
|
@lysu merge failed. |
|
|
/merge |
|
/run-all-tests |
|
@lysu merge failed. |
jackysp
approved these changes
Jul 14, 2020
ti-srebot
added
status/LGT3
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@lysu merge failed. |
|
/run-unit-test |
|
/merge |
|
/run-all-tests |
|
@lysu merge failed. |
|
/merge |
|
/run-all-tests |
|
@lysu merge failed. |
|
/run-unit-test |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jul 14, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #18562 |
coocood
pushed a commit
that referenced
this pull request
Jul 15, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com> Co-authored-by: lysu <sulifx@gmail.com>
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: refer #18339
Problem Summary:
when panic like #18339 happened, batchClient will recovery from panic without reCreate stream and meet panic again and again...
What is changed and how it works?
What's Changed, How it Works:
although we didn't know how to broke transportReader, we can break infinite panic by covert panic to an error in
recvmethod, then the error will trigger reCreate streammake it recovery from broken transportReader
Related changes
Check List
Tests
Side effects
Release note
This change is