Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: make column default value being aware of NO_ZERO_IN_DATE #24174

Merged
merged 4 commits into from
Apr 21, 2021
Merged

executor: make column default value being aware of NO_ZERO_IN_DATE #24174

merged 4 commits into from
Apr 21, 2021

Conversation

tangenta
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #24165

Problem Summary:

ResetContextOfStmt() does not set IgnoreZeroInDate to the statement context, resulting in a parse error about zero-date default value.

What is changed and how it works?

What's Changed: Reset AllowInvalidDate and IgnoreZeroInDate for create table statements.

Related changes

NA

Check List

Tests

  • Unit test
  • Integration test

Side effects

NA

Release note

  • Fix an issue that NO_ZERO_IN_DATE SQL mode does not work in default value

@tangenta tangenta requested a review from a team as a code owner April 20, 2021 09:30
@tangenta tangenta requested review from lzmhhh123 and removed request for a team April 20, 2021 09:30
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 20, 2021
@AilinKid
Copy link
Contributor

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 20, 2021
@crazycs520
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • AilinKid
  • crazycs520

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 20, 2021
@github-actions github-actions bot added the sig/execution SIG execution label Apr 20, 2021
@tangenta
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

@tangenta: /merge is only allowed for the committers in list.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@crazycs520
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 527711d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 21, 2021
@ti-chi-bot ti-chi-bot merged commit 2e52da6 into pingcap:master Apr 21, 2021
ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 21, 2021
@ti-srebot
cherry pick pingcap#24174 to release-4.0
b93e225 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 21, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #24185

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 21, 2021
@ti-srebot
cherry pick pingcap#24174 to release-5.0
6b802f5 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 21, 2021
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #24186

ti-chi-bot pushed a commit that referenced this pull request May 10, 2021
@ti-srebot
executor: make column default value being aware of NO_ZERO_IN_DATE (#…
b130ae3 
…24174) (#24185)
@tisonkun tisonkun mentioned this pull request Jun 11, 2021
Closed
@bb7133 bb7133 mentioned this pull request Aug 1, 2021
Closed
@tangenta tangenta mentioned this pull request Aug 3, 2021
Merged
12 tasks
This was referenced Aug 4, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 Awaiting requested review from lzmhhh123

@crazycs520 crazycs520 Awaiting requested review from crazycs520

@AilinKid AilinKid Awaiting requested review from AilinKid

Assignees
No one assigned
Labels
needs-cherry-pick-release-5.0 sig/execution SIG execution size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NO_ZERO_IN_DATE does not work in default value
6 participants
@tangenta @AilinKid @crazycs520 @ti-chi-bot @ti-srebot @ngaut