-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: not push invalid cast to tiflash (#28458) #28652
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-srebot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-all-tests |
@windtalker you're already a collaborator in bot's repo. |
This pull request is closed because it's related version has closed automatic cherry-picking. You can find more details at: |
cherry-pick #28458 to release-5.1
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/28652
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #23907
Problem Summary:
As the issue described.
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
The root cause of this error is for cast function like
castIntAsInt
, TiDB's implementation iscastIntAsInt64
, so in order to be consistent with TiDB, TiFlash's cast only support cast something toInt64
. However, the return type ofcastIntAsInt
is not alwaysInt64
, if the return type isInt32
, TiFlash will try to cast something toInt32
, this will cause TiFlash throwtidb_cast to Int32 is not supported
error. This pr check the return type ofcast
function, and only allow it to be pushed down to TiFlash if supported.Check List
Tests
Side effects
Documentation
Release note