-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression: not push invalid cast to tiflash (#28458) #28654
expression: not push invalid cast to tiflash (#28458) #28654
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@windtalker you're already a collaborator in bot's repo. |
PTLA @fzhedu @lzmhhh123 |
1 similar comment
PTLA @fzhedu @lzmhhh123 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
/merge |
@fzhedu: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
@zhouqiang-cl: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 58f66ee
|
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #28458 to release-5.2
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/28654
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #23907
Problem Summary:
As the issue described.
What is changed and how it works?
Proposal: xxx
What's Changed:
How it Works:
The root cause of this error is for cast function like
castIntAsInt
, TiDB's implementation iscastIntAsInt64
, so in order to be consistent with TiDB, TiFlash's cast only support cast something toInt64
. However, the return type ofcastIntAsInt
is not alwaysInt64
, if the return type isInt32
, TiFlash will try to cast something toInt32
, this will cause TiFlash throwtidb_cast to Int32 is not supported
error. This pr check the return type ofcast
function, and only allow it to be pushed down to TiFlash if supported.Check List
Tests
Side effects
Documentation
Release note