-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: fix bug that aggregate push down may generate wrong plan for outer joins (#34468) #34647
planner: fix bug that aggregate push down may generate wrong plan for outer joins (#34468) #34647
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/run-all-tests |
@Reminiscent you're already a collaborator in bot's repo. |
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
08bfe00
to
82ec1d7
Compare
/run-all-tests |
Code Coverage Details: https://codecov.io/github/pingcap/tidb/commit/6b74e86c2aadfcddc465e980e3b9f27afcb4a66b |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 82ec1d7
|
/run-unit-test |
@ti-srebot: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
cherry-pick #34468 to release-5.2
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/34647
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #34465
Problem Summary:
When we push down aggregate past outer join, the top count aggregate assumed
that the partial count aggregate always return non-null value. But in case of
outer joins when the aggregate is pushed down to the null generating side of
the outer join, the input for the final aggregate may be nullable.
Before this patch, the final count aggregate always assume its input is not
nullable, hence during aggregate elimination, the optimizer rewrote aggregate
into a plain column of null-generating side of outer join, which led to the
wrong result.
Check List
Tests
Side effects
Documentation
Release note