-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: don't push down topN when the expressions in projection is mutable effective #37996
base: master
Are you sure you want to change the base?
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8542943
|
/hold |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 96cfca0
|
@Reminiscent: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/run-mysql-test |
/hold |
The test case will failed after this PR.
We should get the answer 3, but it will get answer 1. Because of we execute projection first, and then do the sort.(Both MySQL and PG). |
@Reminiscent: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…utable effective
What problem does this PR solve?
Issue Number: close #37986
Problem Summary:
planner: don't push down topN when the expressions in projection is mutable effective
What is changed and how it works?
planner: don't push down topN when the expressions in projection is mutable effective
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.