Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telemetry: set switch default to false #41336

Merged
merged 2 commits into from
Feb 14, 2023
Merged

telemetry: set switch default to false #41336

merged 2 commits into from
Feb 14, 2023

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #41335

Problem Summary: Disable Telemetry report by default.

What is changed and how it works?

Changed the switch default of EnableTelemetry from true to false.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Disable telemetry report by default.

@AstroProfundis AstroProfundis requested a review from a team as a code owner February 13, 2023 07:19
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 13, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • XuHuaiyu
  • breezewish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 13, 2023
@AstroProfundis
Copy link
Contributor Author

I have no idea why these tests failed.

@YangKeao
Copy link
Member

/retest

@breezewish
Copy link
Member

breezewish commented Feb 14, 2023 •
edited
Loading

There are two switches in TiDB:

Telemetry Config: not dynamically updatable
Telemetry Variable: dynamically updatable

Telemetry will be enabled iff both are true.

I would suggest you to change telemetry variable to OFF by default (and remove the telemetry config), so that user could enable telemetry dynamically (if needed).

@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2023
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 14, 2023
@AstroProfundis
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 14, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2023
@XuHuaiyu
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: dae814c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2023
@ti-chi-bot ti-chi-bot merged commit dde0c6c into pingcap:master Feb 14, 2023
AstroProfundis added a commit to AstroProfundis/tidb that referenced this pull request Feb 14, 2023
@AstroProfundis
telemetry: set switch default to false (pingcap#41336)
414fdfb 
close pingcap#41335
@AstroProfundis AstroProfundis deleted the disable-telemetry branch February 14, 2023 07:34
@AstroProfundis AstroProfundis mentioned this pull request Feb 14, 2023
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this pull request Feb 14, 2023
@AstroProfundis
telemetry: set switch default to false (#41336) (#41384)
beddc60
@AstroProfundis
Copy link
Contributor Author

/cherry-pick release-6.5
/cherry-pick release-6.1
/cherry-pick release-5.4

@ti-chi-bot ti-chi-bot mentioned this pull request Feb 15, 2023
Open
12 tasks
@ti-chi-bot
Copy link
Member

@AstroProfundis: new pull request created to branch release-5.4: #41435.

In response to this:

/cherry-pick release-6.5
/cherry-pick release-6.1
/cherry-pick release-5.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 15, 2023
@AstroProfundis @ti-chi-bot
This is an automated cherry-pick of pingcap#41336
646cf92 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 15, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

@AstroProfundis: new pull request created to branch release-6.1: #41436.

In response to this:

/cherry-pick release-6.5
/cherry-pick release-6.1
/cherry-pick release-5.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/tidb that referenced this pull request Feb 15, 2023
@AstroProfundis @ti-chi-bot
This is an automated cherry-pick of pingcap#41336
d4e1252 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 15, 2023
Merged
12 tasks
@ti-chi-bot
Copy link
Member

@AstroProfundis: new pull request created to branch release-6.5: #41439.

In response to this:

/cherry-pick release-6.5
/cherry-pick release-6.1
/cherry-pick release-5.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

blacktear23 pushed a commit to blacktear23/tidb that referenced this pull request Feb 15, 2023
@AstroProfundis @blacktear23
telemetry: set switch default to false (pingcap#41336)
dc368c4 
close pingcap#41335
ghazalfamilyusa pushed a commit to ghazalfamilyusa/tidb that referenced this pull request Feb 15, 2023
@AstroProfundis @ghazalfamilyusa
telemetry: set switch default to false (pingcap#41336)
c99c44c 
close pingcap#41335
This was referenced Feb 17, 2023
Merged
Open
ti-chi-bot pushed a commit that referenced this pull request Feb 21, 2023
@AstroProfundis
telemetry: set switch default to false (#41336) (#41542)
73d82e3 
ref #41335
iosmanthus pushed a commit to iosmanthus/tidb that referenced this pull request Feb 28, 2023
@AstroProfundis @iosmanthus
telemetry: set switch default to false (pingcap#41336) (pingcap#41384)
0f6e1a8
ti-chi-bot added a commit that referenced this pull request Feb 28, 2023
@ti-chi-bot
telemetry: set switch default to false (#41336) (#41439)
c78e413 
close #41335
@bb7133 bb7133 mentioned this pull request Dec 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuHuaiyu XuHuaiyu XuHuaiyu approved these changes

@breezewish breezewish breezewish approved these changes

Assignees
No one assigned
Labels
release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make tidb telemetry default off
5 participants
@AstroProfundis @ti-chi-bot @YangKeao @breezewish @XuHuaiyu