-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: stabilize tests in binary_plan_test.go
#41356
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
binary_plan_test.go
binary_plan_test.go
/test ? |
@time-and-fate: The following commands are available to trigger required jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/check-issue-triage-complete |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: c4b9292
|
What problem does this PR solve?
Issue Number: close #40004 close #41297
Problem Summary:
Try to fix the above two unstable test cases.
What is changed and how it works?
TestTooLongBinaryPlan
: I'm unable to reproduce this fail. But I suspect this is because this case is affected by other cases. So I disable and then enable stmt summary in this case to trigger clear the stmt summary in memory, hoping this can fix the problem.TestLongBinaryPlan
: I added a rather strict check when I wrote this test case. It looks like this is too strict and even small changes might break this case. So I removed some non-necessary checks.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.