Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: improve test to make test more fast #41403

Merged
merged 5 commits into from
Feb 14, 2023
Merged

statistics: improve test to make test more fast #41403

merged 5 commits into from
Feb 14, 2023

Conversation

hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Feb 14, 2023 •
edited
Loading

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What problem does this PR solve?

Issue Number: ref #41377

Problem Summary:

What is changed and how it works?

  1. update some bazel config. set timeout as short and increase the shard_count
  2. split some test cases into new folders. it can add concurrency for the test cases.
    because bezel's max concurrency is 50 in a folder.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@hawkingrei
statistics: improve test to make test more fast
f7910b9 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 14, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • sticnarf
  • time-and-fate

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Feb 14, 2023
@hawkingrei
*: update bazel
565920f 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
*: update bazel
d4dee43 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 14, 2023
@hawkingrei
*: update bazel
1f8aaf6 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2023
@hawkingrei
*: update bazel
9ae2d33 
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Member Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9ae2d33

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2023
@ti-chi-bot ti-chi-bot merged commit e0620da into pingcap:master Feb 14, 2023
@hawkingrei hawkingrei deleted the improve_handle_tester branch February 14, 2023 13:52
blacktear23 pushed a commit to blacktear23/tidb that referenced this pull request Feb 15, 2023
@hawkingrei @blacktear23
statistics: improve test to make test more fast (pingcap#41403)
e5fc15c 
ref pingcap#41377
ghazalfamilyusa pushed a commit to ghazalfamilyusa/tidb that referenced this pull request Feb 15, 2023
@hawkingrei @ghazalfamilyusa
statistics: improve test to make test more fast (pingcap#41403)
2067b5d 
ref pingcap#41377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@sticnarf sticnarf sticnarf approved these changes

@lance6716 lance6716 Awaiting requested review from lance6716

@AilinKid AilinKid Awaiting requested review from AilinKid

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hawkingrei @ti-chi-bot @sticnarf @time-and-fate