Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: clean the one side filters for outer join reorder which is not done in #44409 (#45565) #45585

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #45565

What problem does this PR solve?

Issue Number: close #45564 , ref #44409

Problem Summary:

What is changed and how it works?

In #44409 , we only cleaned the other conditions, but the one side filters will also need to be checked.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Fix the case that the join predicates might be put in the wrong place.

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 26, 2023
@ti-chi-bot ti-chi-bot added type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jul 26, 2023
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 26, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 8, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-6.5@5a5cad1). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-6.5     #45585   +/-   ##
================================================
  Coverage               ?   73.7713%           
================================================
  Files                  ?       1083           
  Lines                  ?     348215           
  Branches               ?          0           
================================================
  Hits                   ?     256883           
  Misses                 ?      74904           
  Partials               ?      16428           

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 16, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, time-and-fate

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [AilinKid,time-and-fate]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 16, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 16, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-16 04:12:36.973086259 +0000 UTC m=+690721.522102241: ☑️ agreed by time-and-fate.
  • 2023-08-16 04:34:56.050028008 +0000 UTC m=+692060.599043980: ☑️ agreed by AilinKid.

@ti-chi-bot ti-chi-bot bot merged commit ed1988d into pingcap:release-6.5 Aug 16, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/planner SIG: Planner size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants