-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
br: configure the httpclient for external storage (#46040) #46140
br: configure the httpclient for external storage (#46040) #46140
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Signed-off-by: Leavrth <jianjun.liao@outlook.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #46140 +/- ##
================================================
Coverage ? 73.6577%
================================================
Files ? 1083
Lines ? 347784
Branches ? 0
================================================
Hits ? 256170
Misses ? 75163
Partials ? 16451 |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3pointer, Leavrth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #46040
What problem does this PR solve?
Issue Number: close #46011
Problem Summary:
br use the default http client to connect the external storage, which doesn't have enough reuse-connection-pool for each host(the default value is 2). This leads to slow batch files processing and TCP connections exceeding the system configuration limit.
What is changed and how it works?
set the
MaxIdleConnsPerHost
as the same asMaxIdleConns
.Check List
Tests
before configuration
after configuration
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.