Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add global variable tidb_schema_version_cache_limit to control infoschema cache size and refine metric #46684

Merged
merged 6 commits into from
Sep 11, 2023
Merged

*: add global variable tidb_schema_version_cache_limit to control infoschema cache size and refine metric #46684

merged 6 commits into from
Sep 11, 2023

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary: cherry-pick:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@crazycs520
metrics: refine metrics of infoschema (pingcap#46612)
f0f4dea 
ref pingcap#46524
@crazycs520
refien
2b0af39 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
refine
a5ec8b5 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
add global variable tidb_info_schema_cache_size to control infoschem…
3fe29f8 
…a cache size

    Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520
refine
f7d8eee 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@crazycs520 crazycs520 requested a review from a team as a code owner September 5, 2023 10:38
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 5, 2023
@tiprow
Copy link

tiprow bot commented Sep 5, 2023

Hi @crazycs520. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crazycs520
Copy link
Contributor Author

test see #46694

@cfzjywxk
Copy link
Contributor

cfzjywxk commented Sep 6, 2023 •
edited
Loading

@zyguan @you06 @ekexium

/cc @hihihuhu @Tema

PTAL

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 6, 2023

@cfzjywxk: GitHub didn't allow me to request PR reviews from the following users: hihihuhu, Tema.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@zyguan @you06 @ekexium
PTAL
/cc @hihihuhu @Tema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@crazycs520 crazycs520 changed the title *: add global variable tidb_info_schema_cache_size to control infoschema cache size and refine metric *: add global variable tidb_schema_version_cache_limit to control infoschema cache size and refine metric Sep 6, 2023
@crazycs520
rename to tidb_schema_version_cache_limit
80ce5f6 
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 6, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-06 14:26:54.119420854 +0000 UTC m=+2541978.668436841: ☑️ agreed by zyguan.

@ti-chi-bot ti-chi-bot bot added the approved label Sep 6, 2023
@hihihuhu
Copy link
Contributor

hihihuhu commented Sep 6, 2023

lgtm, thanks!

@bb7133
Copy link
Member

bb7133 commented Sep 8, 2023

/retest

@bb7133
Copy link
Member

bb7133 commented Sep 8, 2023

/run-unit-test

@bb7133
Copy link
Member

bb7133 commented Sep 8, 2023

/run-mysql-test

@bb7133
Copy link
Member

bb7133 commented Sep 8, 2023

/run-unit-test

1 similar comment
@bb7133
Copy link
Member

bb7133 commented Sep 8, 2023

/run-unit-test

@bb7133
Copy link
Member

bb7133 commented Sep 8, 2023

Failed test:

[2023-09-08T16:55:57.671Z]         	Error Trace:	/home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/br/pkg/task/restore_test.go:72
[2023-09-08T16:55:57.671Z]         	Error:      	Not equal: 
[2023-09-08T16:55:57.671Z]         	            	expected: 0x11
[2023-09-08T16:55:57.671Z]         	            	actual  : 0x10
[2023-09-08T16:55:57.671Z]         	Test:       	TestAdjustRestoreConfigForStreamRestore

@crazycs520 crazycs520 merged commit 606952c into pingcap:tidb-6.5-with-kv-timeout-feature Sep 11, 2023
guoshouyan pushed a commit to guoshouyan/tidb that referenced this pull request Mar 5, 2024
@Tema @crazycs520
*: add global variable tidb_schema_version_cache_limit to control inf…
d0fc624 
…oschema cache size and refine metric (pingcap#46684) (pingcap#4)

Signed-off-by: crazycs520 <crazycs520@gmail.com>

Signed-off-by: crazycs520 <crazycs520@gmail.com>
Co-authored-by: crazycs <crazycs520@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zyguan zyguan zyguan approved these changes

Assignees
No one assigned
Labels
approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crazycs520 @cfzjywxk @hihihuhu @bb7133 @zyguan