-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: Fix crash during sort spill (#47581) #47624
executor: Fix crash during sort spill (#47581) #47624
Conversation
/test unit-test |
@windtalker: No presubmit jobs available for pingcap/tidb@release-6.5 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release-6.5 #47624 +/- ##
================================================
Coverage ? 73.6793%
================================================
Files ? 1085
Lines ? 348399
Branches ? 0
================================================
Hits ? 256698
Misses ? 75233
Partials ? 16468 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: windtalker, zanmato1984 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This is an automated cherry-pick of #47581
What problem does this PR solve?
Issue Number: close #47538
Problem Summary:
What is changed and how it works?
baseSpillDiskAction
forSpillDiskAction
andSortAndSpillDiskAction
, soSortAndSpillDiskAction
don't have to hold a uselessRowContainer
c *SortedRowContainer) Sort()
to avoid panicCheck List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.