Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add expression default values feature relevant tests and fix the "extra" field issue. #51482

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Mar 4, 2024

What problem does this PR solve?

Issue Number: close #51462, close #51481

Problem Summary:

What changed and how does it work?

  • Add expression default values feature relevant tests for different data types and default keywords.
  • Fix the issue of that the "extra" field in the result of "show columns" with default value expressions is not processed.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 4, 2024
Copy link

tiprow bot commented Mar 4, 2024

Hi @zimulala. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Merging #51482 (26c0cdc) into master (718c7a3) will increase coverage by 2.1824%.
Report is 28 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #51482        +/-   ##
================================================
+ Coverage   70.7479%   72.9303%   +2.1824%     
================================================
  Files          1462       1463         +1     
  Lines        435179     440094      +4915     
================================================
+ Hits         307880     320962     +13082     
+ Misses       108058      98987      -9071     
- Partials      19241      20145       +904     
Flag Coverage Δ
integration 49.1604% <100.0000%> (?)
unit 70.4544% <100.0000%> (-0.0980%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 51.6782% <ø> (+5.7976%) ⬆️

@pingcap pingcap deleted a comment from ti-chi-bot bot Mar 4, 2024
SELECT * from t1;
c c1
INSERT INTO t2 values ();
Error 1265 (01000): Data truncated for column '%s' at row %d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a bug? Maybe we already have a same issue, please check it.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 5, 2024
Copy link

ti-chi-bot bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Defined2014, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 5, 2024
Copy link

ti-chi-bot bot commented Mar 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-05 03:43:24.77790334 +0000 UTC m=+138631.800149728: ☑️ agreed by Defined2014.
  • 2024-03-05 05:50:36.754618809 +0000 UTC m=+146263.776865194: ☑️ agreed by tangenta.

@zimulala
Copy link
Contributor Author

zimulala commented Mar 5, 2024

/test unit-test

Copy link

tiprow bot commented Mar 5, 2024

@zimulala: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot merged commit 6192717 into pingcap:master Mar 5, 2024
23 checks passed
@zimulala zimulala deleted the zimuxia/default-expr-tests branch March 7, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
3 participants