Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: stop pushing TopN down through Projection if it has undeterministic functions (#53362) #53811

Merged
merged 2 commits into from
Jun 10, 2024
Merged

planner: stop pushing TopN down through Projection if it has undeterministic functions (#53362) #53811

merged 2 commits into from
Jun 10, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #53362

What problem does this PR solve?

Issue Number: close #37986

Problem Summary: planner: stop pushing TopN down through Projection if it has undeterministic functions

What changed and how does it work?

planner: stop pushing TopN down through Projection if it has undeterministic functions

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@qw4990 @ti-chi-bot
This is an automated cherry-pick of pingcap#53362
c7b28e9 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Jun 4, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 4, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 4, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 4, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 7, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jun 7, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 7, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 7, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-07 06:32:19.724516512 +0000 UTC m=+100693.777828515: ☑️ agreed by qw4990.
  • 2024-06-07 06:32:51.312777481 +0000 UTC m=+100725.366089405: ☑️ agreed by hawkingrei.

@qw4990
Copy link
Contributor

qw4990 commented Jun 7, 2024

/test unit-test

@tiprow tiprow
Copy link

tiprow bot commented Jun 7, 2024

@qw4990: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@fixdb
Copy link
Contributor

fixdb commented Jun 10, 2024

/test unit-test

fixdb
fixdb approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@fixdb fixdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@tiprow tiprow
Copy link

tiprow bot commented Jun 10, 2024

@fixdb: No presubmit jobs available for pingcap/tidb@release-6.5

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fixdb, hawkingrei, qw4990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 236b1b7 into pingcap:release-6.5 Jun 10, 2024
8 checks passed
@qw4990
Copy link
Contributor

qw4990 commented Jun 11, 2024

/test unit-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qw4990 qw4990 qw4990 approved these changes

@hawkingrei hawkingrei hawkingrei approved these changes

@fixdb fixdb fixdb approved these changes

Assignees

@qw4990 qw4990

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm ok-to-test Indicates a PR is ready to be tested. release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @qw4990 @fixdb @hawkingrei