Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression/types: fix decimal minus/round/multiple result #7001

Merged
merged 9 commits into from
Jul 11, 2018
Merged

expression/types: fix decimal minus/round/multiple result #7001

merged 9 commits into from
Jul 11, 2018

Commits on Jul 9, 2018

  1. expression/types: fix negative small decimal bug. 

    In detail fix two question:

- minus sign direct change decimal's negative property
- write decimal's round no longer truncate scale param any more

fixes #6997
    @lysu
    lysu committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    6668431 View commit details
    Browse the repository at this point in the history

  2. fix decimal derive in round/truncate.

    @lysu
    lysu committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    2ef808c View commit details
    Browse the repository at this point in the history

  3. fix testcase..maybe need more fix.

    @lysu
    lysu committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    7bba6ba View commit details
    Browse the repository at this point in the history

  4. make testcase back to right.

    @lysu
    lysu committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    3de2dd1 View commit details
    Browse the repository at this point in the history

  5. fix issue #6985 that decimal mul cause panic

    @lysu
    lysu committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    039feff View commit details
    Browse the repository at this point in the history

  6. fix comment, should not remove old case.

    @lysu
    lysu committed Jul 9, 2018
    Configuration menu
    Copy the full SHA
    126d875 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2018

  1. add testcase for decimal mul datatrucate

    @lysu
    lysu committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    0151f10 View commit details
    Browse the repository at this point in the history

  2. address comment~

    @lysu
    lysu committed Jul 11, 2018
    Configuration menu
    Copy the full SHA
    f36ed84 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into dev-decimal-mul-fix

    @zz-jason
    zz-jason authored Jul 11, 2018
    Configuration menu
    Copy the full SHA
    7d1dbcd View commit details
    Browse the repository at this point in the history