-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expression/json: add builtin function JSON_SEARCH #8704
Conversation
@XuHuaiyu PTAL |
@XuHuaiyu PTAL, thanks! |
f125510
to
187a132
Compare
@pingyu CI is failed, could you fix it in your spare time? |
187a132
to
f05d889
Compare
Codecov Report
@@ Coverage Diff @@
## master #8704 +/- ##
================================================
- Coverage 77.9673% 77.5371% -0.4302%
================================================
Files 407 404 -3
Lines 82718 81971 -747
================================================
- Hits 64493 63558 -935
- Misses 13452 13686 +234
+ Partials 4773 4727 -46 |
@zz-jason CI was fixed. PTAL. Thanks. |
Nice work! @pingyu But I think variable |
87bb029
to
d1673ca
Compare
LGTM |
d1673ca
to
1a17445
Compare
@zz-jason PTAL |
7c2b59e
to
ce821b3
Compare
ce821b3
to
c8bc4a8
Compare
c8bc4a8
to
8f17c6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
What problem does this PR solve?
Add json builtin function JSON_SEARCH described in #7546
What is changed and how it works?
Add struct builtinJSONSearchSig, 2 functions for
walking
and utility for string quoting to BinaryJSON, and 3 utility function for json PathExpressionCheck List
Tests
Code changes
BinaryJSON.Walk, PathExpression.String
Side effects
Related changes
JSON_SEARCH supported
This change is