Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

join should be aware of cancel signal #9430

Closed
windtalker opened this issue Sep 14, 2024 · 0 comments · Fixed by #9450
Closed

join should be aware of cancel signal #9430

windtalker opened this issue Sep 14, 2024 · 0 comments · Fixed by #9450
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. component/compute report/customer Customers have encountered this bug. severity/major type/bug The issue is confirmed as a bug.

Comments

@windtalker
Copy link
Contributor

Bug Report

Please answer these questions before submitting your issue. Thanks!
Currently, inside join, it does not aware of cancel signal, so if you wants to cancel a query that contains join, it can only wait until joinBlock returns

https://github.com/pingcap/tiflash/blob/v8.3.0/dbms/src/Interpreters/Join.h#L201

If joinBlock() takes a long time(it could happen in some extrame cases, like cross join with a lot of build side data), the query can not be cancelled for a long time

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiFlash version? (Required)
@windtalker windtalker added type/bug The issue is confirmed as a bug. component/compute labels Sep 14, 2024
@windtalker windtalker added affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. and removed may-affects-5.4 may-affects-6.1 may-affects-6.5 may-affects-7.1 may-affects-7.5 may-affects-8.1 labels Sep 18, 2024
@windtalker windtalker mentioned this issue Sep 20, 2024
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot closed this as completed in 8aba9f0 Sep 21, 2024
This was referenced Sep 21, 2024
Merged
Merged
Merged
Open
@windtalker windtalker mentioned this issue Sep 23, 2024
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Sep 23, 2024
@windtalker
fix tiflash assert failure (#9456)
78bd3f0 
ref #9430

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
This was referenced Sep 23, 2024
Open
Closed
Closed
Closed
windtalker added a commit to ti-chi-bot/tiflash that referenced this issue Sep 23, 2024
@windtalker
fix tiflash assert failure (pingcap#9456)
9ff629e 
ref pingcap#9430

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
windtalker added a commit to ti-chi-bot/tiflash that referenced this issue Sep 23, 2024
@windtalker
fix tiflash assert failure (pingcap#9456)
452ba44 
ref pingcap#9430

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
ti-chi-bot bot pushed a commit that referenced this issue Sep 26, 2024
@ti-chi-bot @windtalker
join be aware of cancel signal (#9450) (#9453)
2faf287 
close #9430

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>

Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn>
ti-chi-bot bot added a commit that referenced this issue Sep 27, 2024
@ti-chi-bot @windtalker @ti-chi-bot
join be aware of cancel signal (#9450) (#9452)
a2a4c88 
close #9430

Co-authored-by: xufei <xufei@pingcap.com>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added the report/customer Customers have encountered this bug. label Oct 11, 2024
ti-chi-bot bot added a commit that referenced this issue Nov 1, 2024
@ti-chi-bot @windtalker @ti-chi-bot
join be aware of cancel signal (#9450) (#9454)
1d5458b 
close #9430

Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>

Co-authored-by: xufei <xufei@pingcap.com>
Co-authored-by: xufei <xufeixw@mail.ustc.edu.cn>
Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-7.1 This bug affects the 7.1.x(LTS) versions. affects-7.5 This bug affects the 7.5.x(LTS) versions. affects-8.1 This bug affects the 8.1.x(LTS) versions. component/compute report/customer Customers have encountered this bug. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

join be aware of cancel signal windtalker/tiflash
2 participants
@windtalker @jebter