Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLASH-37] Json support #159

Merged
merged 21 commits into from
Aug 22, 2019
Merged

[FLASH-37] Json support #159

merged 21 commits into from
Aug 22, 2019

Conversation

ilovesoup
Copy link
Contributor

Implement json support. For now it decodes to string. But when TiDB / TiSpark supports tiflash, we need to change to lazy decode plus json function pushdown.

@ilovesoup ilovesoup changed the title [DNM] Json support Json support Aug 15, 2019
@zanmato1984
Copy link
Contributor

Please resolve conflicts with master.

@ilovesoup ilovesoup changed the title Json support [FLASH-37] Json support Aug 16, 2019
@zanmato1984
Copy link
Contributor

Coding styles:

  1. We use <> include instead of "";
  2. Too many blank lines in several places;
  3. Do a clang-format to all the affected files.

solotzg
solotzg reviewed Aug 16, 2019
View reviewed changes
dbms/src/Storages/Transaction/JSONCodec.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/JSONCodec.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/JSONCodec.h Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/JSONCodec.h Outdated Show resolved Hide resolved
@zanmato1984
Copy link
Contributor

Coding styles:

  1. We use <> include instead of "";
  2. Too many blank lines in several places;
  3. Do a clang-format to all the affected files.

@ilovesoup PTAL this comment.

zanmato1984
zanmato1984 approved these changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solotzg
Copy link
Contributor

solotzg commented Aug 19, 2019

please learn to use std::move to reduce unnecessary memory copy.

@ilovesoup
Copy link
Contributor Author

/run-integration-tests

solotzg
solotzg approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@solotzg solotzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilovesoup
Copy link
Contributor Author

/run-integration-tests

@ilovesoup ilovesoup merged commit 84ededb into master Aug 22, 2019
@ilovesoup ilovesoup deleted the json_support branch August 22, 2019 12:28
@CalvinNeo CalvinNeo mentioned this pull request Nov 7, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanfei1991 hanfei1991 hanfei1991 left review comments

@solotzg solotzg solotzg approved these changes

@zanmato1984 zanmato1984 zanmato1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ilovesoup @zanmato1984 @solotzg @hanfei1991 @ilovesoup2000