Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize schema sync on read and refine mock TiDB #170

Merged
merged 5 commits into from
Aug 9, 2019
Merged

Optimize schema sync on read and refine mock TiDB #170

merged 5 commits into from
Aug 9, 2019

Conversation

zanmato1984
Copy link
Contributor

  1. Optimize schema sync on read, by doing anther comparing between query schema version and global schema version. This may give us a chance of not doing the unnecessary round of schema sync.
  2. Refine mock TiDB by doing region dropping inside, make code clean.

@zanmato1984 zanmato1984 requested a review from hanfei1991 August 8, 2019 23:31
@zanmato1984
Copy link
Contributor Author

/run-integration-tests

hanfei1991
hanfei1991 approved these changes Aug 9, 2019
View reviewed changes
Copy link
Member

@hanfei1991 hanfei1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanmato1984
Copy link
Contributor Author

/run-integration-tests

@zanmato1984 zanmato1984 merged commit a1956bc into master Aug 9, 2019
@zanmato1984 zanmato1984 deleted the opt-ddl branch August 9, 2019 07:06
@CalvinNeo CalvinNeo mentioned this pull request Sep 15, 2022
Merged
12 tasks
@CalvinNeo CalvinNeo mentioned this pull request Nov 7, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanfei1991 hanfei1991 hanfei1991 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zanmato1984 @hanfei1991