Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flash-443] fix drop and add column with same name #193

Merged
merged 2 commits into from
Aug 23, 2019

Conversation

hanfei1991
Copy link
Member

@hanfei1991 hanfei1991 commented Aug 22, 2019

When drop and add column with same name in a batch operators, we always add column firstly, that will cause we try to create a column with existing column name.

@hanfei1991 hanfei1991 requested a review from zanmato1984 August 22, 2019 08:32
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanfei1991
Copy link
Member Author

/run-integration-tests

@hanfei1991 hanfei1991 merged commit 8920d89 into master Aug 23, 2019
@hanfei1991 hanfei1991 deleted the hanfei-ddl/fix_add_drop_col branch August 23, 2019 14:47
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Aug 2, 2024
Signed-off-by: Wish <breezewish@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants