Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flash-423] fix ch fail to start when tidb cluster is not ready. #203

Merged
merged 4 commits into from
Aug 27, 2019
Merged

[flash-423] fix ch fail to start when tidb cluster is not ready. #203

merged 4 commits into from
Aug 27, 2019

Conversation

hanfei1991
Copy link
Member

@hanfei1991 hanfei1991 commented Aug 26, 2019 •
edited
Loading

retry in an endless loop. By the way, I have tested manually :D

@hanfei1991 hanfei1991 requested a review from zanmato1984 August 26, 2019 12:59
@hanfei1991
Copy link
Member Author

/run-integration-tests

2 similar comments
@hanfei1991
Copy link
Member Author

/run-integration-tests

@hanfei1991
Copy link
Member Author

/run-integration-tests

@hanfei1991
Copy link
Member Author

/run-integration-tests

1 similar comment
@hanfei1991
Copy link
Member Author

/run-integration-tests

innerr
innerr reviewed Aug 27, 2019
View reviewed changes
dbms/src/Server/Server.cpp Outdated
@@ -411,7 +411,19 @@ int Server::main(const std::vector<std::string> & /*args*/)
global_context->setCurrentDatabase(default_database);

/// Then, sync schemas with TiDB, and initialize schema sync service.
global_context->getTMTContext().getSchemaSyncer()->syncSchemas(*global_context);
for (;;)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a retry times?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

innerr
innerr reviewed Aug 27, 2019
View reviewed changes
dbms/src/Server/Server.cpp Outdated
catch (Poco::Exception & e)
{
LOG_ERROR(log, "Bootstrap failed because sync schema error: " << e.displayText() << "\n We will sleep 3 seconds and try again.");
::sleep(3);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sleep(1) is good, will not occupy much CPU

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@hanfei1991
Copy link
Member Author

/run-integration-tests

@hanfei1991
Copy link
Member Author

@innerr PTAL again

innerr
innerr approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@innerr innerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanfei1991 hanfei1991 merged commit 1a9376b into master Aug 27, 2019
@hanfei1991 hanfei1991 deleted the hanfei-ddl/boostrap branch August 27, 2019 16:18
@CalvinNeo CalvinNeo mentioned this pull request Oct 26, 2022
Merged
12 tasks
JaySon-Huang added a commit to JaySon-Huang/tiflash that referenced this pull request Aug 2, 2024
@Lloyd-Pottiger @breezewish @JaySon-Huang
storage: Support adding vector index in background (pingcap#203)
c192e9b 
Signed-off-by: Wish <breezewish@outlook.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Co-authored-by: Wish <breezewish@outlook.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
JaySon-Huang added a commit that referenced this pull request Aug 6, 2024
@Lloyd-Pottiger @breezewish @JaySon-Huang
storage: Support adding vector index in background (#203)
3e20625 
Signed-off-by: Wish <breezewish@outlook.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Co-authored-by: Wish <breezewish@outlook.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
Lloyd-Pottiger added a commit to Lloyd-Pottiger/tiflash that referenced this pull request Aug 28, 2024
@Lloyd-Pottiger @breezewish @JaySon-Huang
storage: Support adding vector index in background (pingcap#203)
7a44dda 
Signed-off-by: Wish <breezewish@outlook.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Co-authored-by: Wish <breezewish@outlook.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
Lloyd-Pottiger added a commit to Lloyd-Pottiger/tiflash that referenced this pull request Aug 30, 2024
@Lloyd-Pottiger @breezewish @JaySon-Huang
storage: Support adding vector index in background (pingcap#203)
f49ee26 
Signed-off-by: Wish <breezewish@outlook.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Co-authored-by: Wish <breezewish@outlook.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
Lloyd-Pottiger added a commit to Lloyd-Pottiger/tiflash that referenced this pull request Sep 5, 2024
@Lloyd-Pottiger @breezewish @JaySon-Huang
storage: Support adding vector index in background (pingcap#203)
8808601 
Signed-off-by: Wish <breezewish@outlook.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Co-authored-by: Wish <breezewish@outlook.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
Lloyd-Pottiger added a commit to Lloyd-Pottiger/tiflash that referenced this pull request Sep 6, 2024
@Lloyd-Pottiger @breezewish @JaySon-Huang
storage: Support adding vector index in background (pingcap#203)
707e91c 
Signed-off-by: Wish <breezewish@outlook.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Co-authored-by: Wish <breezewish@outlook.com>
Co-authored-by: JaySon-Huang <tshent@qq.com>
@CalvinNeo CalvinNeo mentioned this pull request Nov 7, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@innerr innerr innerr approved these changes

@zanmato1984 zanmato1984 Awaiting requested review from zanmato1984

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanfei1991 @innerr