Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FLASH-444: Fix stale table info in metadata #204

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

zanmato1984
Copy link
Contributor

When altering TMT table, refreshing metadata is using stale table info stored in storage object rather than the updated one, which results in query schema version (fetched from metadata) less than the in-memory storage schema version.

Now fix it to using the new one.

@solotzg
Copy link
Contributor

solotzg commented Aug 27, 2019

so, how could it work in the past ?

Copy link
Member

@hanfei1991 hanfei1991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanfei1991
Copy link
Member

/run-integration-tests

@zanmato1984
Copy link
Contributor Author

so, how could it work in the past ?

Our testing didn't cover Spark read after modify column in TiDB. We have add/drop/modify column UT in CI, and we did manual testing of Spark read after add/drop column. Neither of them has covered the case that triggers the bug.

@zanmato1984 zanmato1984 merged commit da0cac9 into master Aug 27, 2019
@zanmato1984 zanmato1984 deleted the fix-stale-table-info branch August 27, 2019 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants