Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flash-363] support rename column #211

Merged
merged 4 commits into from
Sep 2, 2019
Merged

[flash-363] support rename column #211

merged 4 commits into from
Sep 2, 2019

Conversation

hanfei1991
Copy link
Member

We support rename column in this PR. There are some key changes:

  • We drop column firstly, then rename column, then alter column types, then drop column.
  • Every single rename operation is a single alter transcation. This is restriction in CH.
  • For every alter transcation, we simply move data files and rewrite checksums and columns file.

@hanfei1991 hanfei1991 requested a review from zanmato1984 August 30, 2019 08:00
@hanfei1991
Copy link
Member Author

/run-integretion-tests

@hanfei1991
Copy link
Member Author

/run-integration-tests

zanmato1984
zanmato1984 approved these changes Sep 2, 2019
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hanfei1991
Copy link
Member Author

./run-integration-tests

@zanmato1984 zanmato1984 merged commit d81ba74 into master Sep 2, 2019
@zanmato1984 zanmato1984 deleted the hanfei/rename-col branch September 2, 2019 08:10
@CalvinNeo CalvinNeo mentioned this pull request Nov 1, 2022
Merged
12 tasks
@CalvinNeo CalvinNeo mentioned this pull request Nov 7, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hanfei1991 @zanmato1984