Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASH-298] Import delegate mode for Region and RegionMeta #220

Merged
merged 4 commits into from
Sep 4, 2019
Merged

[FLASH-298] Import delegate mode for Region and RegionMeta #220

merged 4 commits into from
Sep 4, 2019

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented Sep 4, 2019

  • Add std::unique_ptr<RaftCommandResult> raft_cmd_res as member of KVStore to store the result of applying raft cmd.

  • Optimize RegionManager.

  • Import RegionRaftCommandDelegate and MetaRaftCommandDelegate to apply raft log.

  • Add function RegionTable::tryFlushRegion(RegionID, TableID).

  • Catch and rethrow exception when try to flush region.

@solotzg solotzg requested a review from innerr September 4, 2019 08:11
@solotzg
Copy link
Contributor Author

solotzg commented Sep 4, 2019

/rebuild

Copy link
Contributor

@innerr innerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solotzg
Copy link
Contributor Author

solotzg commented Sep 4, 2019

/run-integration-tests

3 similar comments
@solotzg
Copy link
Contributor Author

solotzg commented Sep 4, 2019

/run-integration-tests

@solotzg
Copy link
Contributor Author

solotzg commented Sep 4, 2019

/run-integration-tests

@solotzg
Copy link
Contributor Author

solotzg commented Sep 4, 2019

/run-integration-tests

@solotzg
Copy link
Contributor Author

solotzg commented Sep 4, 2019

/run-integration-tests

@solotzg solotzg merged commit 1509cfe into pingcap:master Sep 4, 2019
@solotzg solotzg deleted the pre-FLASH-298-0 branch September 4, 2019 13:52
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Aug 2, 2024
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants