-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLASH-296] [DM] Use Background Threads To Run Delta Merge Operations #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flowbehappy
force-pushed
the
dm-bg-delta-merge
branch
2 times, most recently
from
October 9, 2019 09:32
f7b1b80
to
aaaf62b
Compare
/rebuild |
flowbehappy
force-pushed
the
dm-bg-delta-merge
branch
2 times, most recently
from
October 11, 2019 03:21
1ffea51
to
a37ef91
Compare
dbms/src/Storages/DeltaMerge/tests/gtest_dm_delta_merge_store.cpp
Outdated
Show resolved
Hide resolved
flowbehappy
force-pushed
the
dm-bg-delta-merge
branch
from
October 18, 2019 03:21
9547830
to
9a7b93a
Compare
This comment has been minimized.
This comment has been minimized.
JaySon-Huang
approved these changes
Oct 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flowbehappy
force-pushed
the
dm-bg-delta-merge
branch
3 times, most recently
from
October 18, 2019 10:37
770b8e7
to
8a80bd1
Compare
/run-integration-tests |
flowbehappy
force-pushed
the
dm-bg-delta-merge
branch
from
October 18, 2019 10:39
8a80bd1
to
0f776f1
Compare
/run-integration-tests |
1 similar comment
/run-integration-tests |
The test cases from CHSpark if failed. Will fix it in DeltaMergeEngine branch. Merge it now. |
JaySon-Huang
pushed a commit
that referenced
this pull request
Oct 22, 2019
…#266) * Support merge delta in background. * Avoid slow down query after delete range. * Add a new sql feature manage table tb delete range 100, to test delete range.
JaySon-Huang
pushed a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Oct 23, 2019
…pingcap#266) * Support merge delta in background. * Avoid slow down query after delete range. * Add a new sql feature manage table tb delete range 100, to test delete range.
JaySon-Huang
pushed a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Oct 30, 2019
…pingcap#266) * Support merge delta in background. * Avoid slow down query after delete range. * Add a new sql feature manage table tb delete range 100, to test delete range.
JaySon-Huang
pushed a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Nov 1, 2019
…pingcap#266) * Support merge delta in background. * Avoid slow down query after delete range. * Add a new sql feature manage table tb delete range 100, to test delete range.
JaySon-Huang
pushed a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Nov 1, 2019
…pingcap#266) * Support merge delta in background. * Avoid slow down query after delete range. * Add a new sql feature manage table tb delete range 100, to test delete range.
JaySon-Huang
pushed a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Nov 5, 2019
…pingcap#266) * Support merge delta in background. * Avoid slow down query after delete range. * Add a new sql feature manage table tb delete range 100, to test delete range.
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manage table tb delete range 100
, to test delete range.Note that delete range still have issues: https://internal.pingcap.net/jira/browse/FLASH-583. But let's fix it in next pr.