Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASH-296] [DM] Use Background Threads To Run Delta Merge Operations #266

Merged
merged 8 commits into from
Oct 19, 2019

Conversation

flowbehappy
Copy link
Contributor

@flowbehappy flowbehappy commented Oct 8, 2019

  • Support merge delta in background.
  • Avoid slow down query after delete range.
  • Add a new sql feature manage table tb delete range 100, to test delete range.

Note that delete range still have issues: https://internal.pingcap.net/jira/browse/FLASH-583. But let's fix it in next pr.

@flowbehappy flowbehappy force-pushed the dm-bg-delta-merge branch 2 times, most recently from f7b1b80 to aaaf62b Compare October 9, 2019 09:32
@zyguan
Copy link
Contributor

zyguan commented Oct 9, 2019

/rebuild

dbms/src/Storages/DeltaMerge/Chunk.h Outdated Show resolved Hide resolved
dbms/src/Storages/DeltaMerge/DeltaMergeStore.h Outdated Show resolved Hide resolved
dbms/src/Storages/DeltaMerge/DMContext.h Outdated Show resolved Hide resolved
dbms/src/Storages/Page/PageStorage.h Show resolved Hide resolved
dbms/src/Storages/DeltaMerge/Chunk.cpp Show resolved Hide resolved
@JaySon-Huang

This comment has been minimized.

Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flowbehappy flowbehappy force-pushed the dm-bg-delta-merge branch 3 times, most recently from 770b8e7 to 8a80bd1 Compare October 18, 2019 10:37
@flowbehappy
Copy link
Contributor Author

/run-integration-tests

@flowbehappy
Copy link
Contributor Author

/run-integration-tests

1 similar comment
@JaySon-Huang
Copy link
Contributor

/run-integration-tests

@flowbehappy
Copy link
Contributor Author

The test cases from CHSpark if failed. Will fix it in DeltaMergeEngine branch. Merge it now.

@flowbehappy flowbehappy merged commit 8ecf38a into DeltaMergeEngine Oct 19, 2019
JaySon-Huang pushed a commit that referenced this pull request Oct 22, 2019
…#266)

* Support merge delta in background.
* Avoid slow down query after delete range.
* Add a new sql feature manage table tb delete range 100, to test delete range.
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Oct 23, 2019
…pingcap#266)

* Support merge delta in background.
* Avoid slow down query after delete range.
* Add a new sql feature manage table tb delete range 100, to test delete range.
@JaySon-Huang JaySon-Huang deleted the dm-bg-delta-merge branch October 23, 2019 08:44
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Oct 30, 2019
…pingcap#266)

* Support merge delta in background.
* Avoid slow down query after delete range.
* Add a new sql feature manage table tb delete range 100, to test delete range.
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Nov 1, 2019
…pingcap#266)

* Support merge delta in background.
* Avoid slow down query after delete range.
* Add a new sql feature manage table tb delete range 100, to test delete range.
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Nov 1, 2019
…pingcap#266)

* Support merge delta in background.
* Avoid slow down query after delete range.
* Add a new sql feature manage table tb delete range 100, to test delete range.
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Nov 5, 2019
…pingcap#266)

* Support merge delta in background.
* Avoid slow down query after delete range.
* Add a new sql feature manage table tb delete range 100, to test delete range.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants