-
Notifications
You must be signed in to change notification settings - Fork 412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLASH-453]Support default value of CAST expression #286
[FLASH-453]Support default value of CAST expression #286
Conversation
423553e
to
6799780
Compare
/run-integration-tests |
@JaySon-Huang PTAL |
/run-integration-tests |
Please also commit your changes in |
/run-integration-tests |
/run-integration-tests |
/run-integration-tests |
/rebuild |
/run-integration-tests |
/run-integration-tests |
1 similar comment
/run-integration-tests |
/run-integration-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-integration-tests |
* refactor default_value * Apply suggestions from code review * enable alter default value test * add default_value to make sure read can fill value with it * fix issue with reading Float default value * add test for read Float default value * resolve suggestions * add abs * fix issue with DateTime default value * add test for DateTime default value * modify test case * handle Decimal64 * modify expect values * format * fix issue with Decimal default_value * modify test case * resolve suggestions * fix bug: column in StorageDeltaMerge but not in TiDB::TableInfo::columns
* refactor default_value * Apply suggestions from code review * enable alter default value test * add default_value to make sure read can fill value with it * fix issue with reading Float default value * add test for read Float default value * resolve suggestions * add abs * fix issue with DateTime default value * add test for DateTime default value * modify test case * handle Decimal64 * modify expect values * format * fix issue with Decimal default_value * modify test case * resolve suggestions * fix bug: column in StorageDeltaMerge but not in TiDB::TableInfo::columns
* refactor default_value * Apply suggestions from code review * enable alter default value test * add default_value to make sure read can fill value with it * fix issue with reading Float default value * add test for read Float default value * resolve suggestions * add abs * fix issue with DateTime default value * add test for DateTime default value * modify test case * handle Decimal64 * modify expect values * format * fix issue with Decimal default_value * modify test case * resolve suggestions * fix bug: column in StorageDeltaMerge but not in TiDB::TableInfo::columns
* refactor default_value * Apply suggestions from code review * enable alter default value test * add default_value to make sure read can fill value with it * fix issue with reading Float default value * add test for read Float default value * resolve suggestions * add abs * fix issue with DateTime default value * add test for DateTime default value * modify test case * handle Decimal64 * modify expect values * format * fix issue with Decimal default_value * modify test case * resolve suggestions * fix bug: column in StorageDeltaMerge but not in TiDB::TableInfo::columns
Change
ColumnDefine
: changedefault_value
's type toField