Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASH-453]Support default value of CAST expression #286

Merged
merged 18 commits into from
Oct 29, 2019
Merged

[FLASH-453]Support default value of CAST expression #286

merged 18 commits into from
Oct 29, 2019

Conversation

leiysky
Copy link
Contributor

@leiysky leiysky commented Oct 18, 2019

Change

  • modify ColumnDefine: change default_value's type to Field

@leiysky leiysky requested a review from JaySon-Huang October 18, 2019 06:56
@leiysky leiysky changed the title [FLASH-453] Support default value of CAST expression [FLASH-453]WIP: Support default value of CAST expression Oct 18, 2019
@leiysky
Copy link
Contributor Author

leiysky commented Oct 23, 2019

/run-integration-tests

@leiysky
Copy link
Contributor Author

leiysky commented Oct 23, 2019

@JaySon-Huang PTAL

@leiysky
Copy link
Contributor Author

leiysky commented Oct 24, 2019

/run-integration-tests

dbms/src/Storages/StorageDeltaMerge.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/DeltaMerge/Chunk.cpp Outdated Show resolved Hide resolved
@JaySon-Huang
Copy link
Contributor

Please also commit your changes in tests/delta-merge-test

@leiysky
Copy link
Contributor Author

leiysky commented Oct 28, 2019

/run-integration-tests

@leiysky
Copy link
Contributor Author

leiysky commented Oct 28, 2019

/run-integration-tests

@leiysky leiysky changed the title [FLASH-453]WIP: Support default value of CAST expression [FLASH-453]Support default value of CAST expression Oct 28, 2019
@leiysky
Copy link
Contributor Author

leiysky commented Oct 29, 2019

/run-integration-tests

@leiysky
Copy link
Contributor Author

leiysky commented Oct 29, 2019

/rebuild

@leiysky
Copy link
Contributor Author

leiysky commented Oct 29, 2019

/run-integration-tests

@leiysky
Copy link
Contributor Author

leiysky commented Oct 29, 2019

/run-integration-tests

1 similar comment
@leiysky
Copy link
Contributor Author

leiysky commented Oct 29, 2019

/run-integration-tests

@leiysky
Copy link
Contributor Author

leiysky commented Oct 29, 2019

/run-integration-tests

Copy link
Contributor

@JaySon-Huang JaySon-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JaySon-Huang
Copy link
Contributor

/run-integration-tests

@leiysky leiysky merged commit 0a60644 into pingcap:DeltaMergeEngine Oct 29, 2019
@leiysky leiysky deleted the fix/default-value-in-cast branch October 29, 2019 09:56
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Oct 30, 2019
* refactor default_value

* Apply suggestions from code review

* enable alter default value test

* add default_value to make sure read can fill value with it

* fix issue with reading Float default value

* add test for read Float default value

* resolve suggestions

* add abs

* fix issue with DateTime default value

* add test for DateTime default value

* modify test case

* handle Decimal64

* modify expect values

* format

* fix issue with Decimal default_value

* modify test case

* resolve suggestions

* fix bug: column in StorageDeltaMerge but not in TiDB::TableInfo::columns
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Nov 1, 2019
* refactor default_value

* Apply suggestions from code review

* enable alter default value test

* add default_value to make sure read can fill value with it

* fix issue with reading Float default value

* add test for read Float default value

* resolve suggestions

* add abs

* fix issue with DateTime default value

* add test for DateTime default value

* modify test case

* handle Decimal64

* modify expect values

* format

* fix issue with Decimal default_value

* modify test case

* resolve suggestions

* fix bug: column in StorageDeltaMerge but not in TiDB::TableInfo::columns
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Nov 1, 2019
* refactor default_value

* Apply suggestions from code review

* enable alter default value test

* add default_value to make sure read can fill value with it

* fix issue with reading Float default value

* add test for read Float default value

* resolve suggestions

* add abs

* fix issue with DateTime default value

* add test for DateTime default value

* modify test case

* handle Decimal64

* modify expect values

* format

* fix issue with Decimal default_value

* modify test case

* resolve suggestions

* fix bug: column in StorageDeltaMerge but not in TiDB::TableInfo::columns
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Nov 5, 2019
* refactor default_value

* Apply suggestions from code review

* enable alter default value test

* add default_value to make sure read can fill value with it

* fix issue with reading Float default value

* add test for read Float default value

* resolve suggestions

* add abs

* fix issue with DateTime default value

* add test for DateTime default value

* modify test case

* handle Decimal64

* modify expect values

* format

* fix issue with Decimal default_value

* modify test case

* resolve suggestions

* fix bug: column in StorageDeltaMerge but not in TiDB::TableInfo::columns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants