[FLASH-548/579] Engine DeltaMerge coprocessor integration #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/build |
JaySon-Huang
force-pushed
the
dm-cop-integrate2
branch
from
eb357aa to
6b3ec2e
Compare
|
/run-integration-tests |
JaySon-Huang
force-pushed
the
dm-cop-integrate2
branch
from
6b3ec2e to
34a7c37
Compare
|
/run-integration-tests |
JaySon-Huang
force-pushed
the
dm-cop-integrate2
branch
from
34a7c37 to
23a8eb1
Compare
|
/rebuild |
|
/run-integration-tests |
JaySon-Huang
force-pushed
the
DeltaMergeEngine-rebased
branch
from
8211d01 to
cf61fda
Compare
JaySon-Huang
force-pushed
the
dm-cop-integrate2
branch
from
23a8eb1 to
80f4f89
Compare
JaySon-Huang
force-pushed
the
dm-cop-integrate2
branch
from
80f4f89 to
a808adc
Compare
|
/rebuild |
|
/run-integration-tests |
JaySon-Huang
changed the title
|
/run-integration-tests |
|
/build |
|
/rebuild |
flowbehappy
reviewed
Oct 23, 2019
| @@ -403,6 +403,9 @@ BlockInputStreams StorageDeltaMerge::read( // | |||
| { | |||
| /// Learner read. | |||
| doLearnerRead(tidb_table_info.id, mvcc_query_info.regions_query_info, tmt, log); | |||
|
|
|||
| /// For learner read from TiDB/TiSpark, we set num_streams by `mvcc_query_info.concurrent` | |||
| num_streams = std::max(1U, static_cast<UInt32>(mvcc_query_info.concurrent)); | |||
There was a problem hiding this comment.
Looks like queries from ch client will also run this path. Maybe we should check the availability ofmvcc_query_info to determine whether it is a learner read from TiDB/TiSpark.
There was a problem hiding this comment.
mvcc_query_info is never null, but mvcc_query_info.regions_query_info is empty if it is not come from TiDB/TiSpark.
Done.
|
/rebuild |
2 similar comments
|
/rebuild |
|
/rebuild |
|
LGTM |
flowbehappy
approved these changes
Oct 23, 2019
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Oct 23, 2019
* Throw exception with region status; Use reverseGetColumnInfo * Use IManageableStorage instead of StorageMergeTree * Fix args of mock_tidb_table && ensure engine is DeltaMerge * For learner read from TiDB/TiSpark, we set num_streams by mvcc_query_info.concurrent * fix compile error * address comment; add log for level trace
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Oct 30, 2019
* Throw exception with region status; Use reverseGetColumnInfo * Use IManageableStorage instead of StorageMergeTree * Fix args of mock_tidb_table && ensure engine is DeltaMerge * For learner read from TiDB/TiSpark, we set num_streams by mvcc_query_info.concurrent * fix compile error * address comment; add log for level trace
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Nov 1, 2019
* Throw exception with region status; Use reverseGetColumnInfo * Use IManageableStorage instead of StorageMergeTree * Fix args of mock_tidb_table && ensure engine is DeltaMerge * For learner read from TiDB/TiSpark, we set num_streams by mvcc_query_info.concurrent * fix compile error * address comment; add log for level trace
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Nov 1, 2019
* Throw exception with region status; Use reverseGetColumnInfo * Use IManageableStorage instead of StorageMergeTree * Fix args of mock_tidb_table && ensure engine is DeltaMerge * For learner read from TiDB/TiSpark, we set num_streams by mvcc_query_info.concurrent * fix compile error * address comment; add log for level trace
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Nov 5, 2019
* Throw exception with region status; Use reverseGetColumnInfo * Use IManageableStorage instead of StorageMergeTree * Fix args of mock_tidb_table && ensure engine is DeltaMerge * For learner read from TiDB/TiSpark, we set num_streams by mvcc_query_info.concurrent * fix compile error * address comment; add log for level trace
CalvinNeo
added a commit
to CalvinNeo/tiflash
that referenced
this pull request
Sep 23, 2024
… the remote checkpoint (pingcap#287) Signed-off-by: Calvin Neo <calvinneo1995@gmail.com> Co-authored-by: JaySon <tshent@qq.com>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make coprocessor can read tables with DeltaMerge engine.
There is too many errors after rebase branch DeltaMergeEngine to master without these commits, I create a temporary branch (
DeltaMergeEngine-rebased) and create a PR for review.After reviewed, I will force push this DeltaMergeEngine-rebased to DeltaMergeEngine