Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASH-403] Make flash_cluster_manager run along with flash #298

Merged
merged 6 commits into from
Oct 30, 2019
Merged

[FLASH-403] Make flash_cluster_manager run along with flash #298

merged 6 commits into from
Oct 30, 2019

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented Oct 29, 2019

flash_cluster_manager will detect the pid of tiflash regularly, if not exists, it will kill itself.

@solotzg solotzg requested review from zanmato1984 and innerr October 29, 2019 05:32
@solotzg
Copy link
Contributor Author

solotzg commented Oct 29, 2019

/run-integration-tests

@zanmato1984 zanmato1984 requested review from ilovesoup and removed request for zanmato1984 October 29, 2019 07:34
Copy link
Contributor

@innerr innerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we need to find better way to parse argvs in the future

@solotzg
Copy link
Contributor Author

solotzg commented Oct 29, 2019

/run-integration-tests

@solotzg
Copy link
Contributor Author

solotzg commented Oct 29, 2019

/run-integration-tests

@solotzg solotzg merged commit 0328e28 into pingcap:master Oct 30, 2019
ilovesoup added a commit that referenced this pull request Oct 30, 2019
ilovesoup added a commit that referenced this pull request Oct 30, 2019
CalvinNeo added a commit to CalvinNeo/tiflash that referenced this pull request Nov 14, 2024
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Dec 3, 2024
Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants