[FLASH-463]Flush regions into DM as soon as raft commands processed #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leiysky
requested review from
flowbehappy and
JaySon-Huang
and removed request for
flowbehappy
|
/rebuild |
|
/run-integration-tests |
|
/run-integration-tests |
|
/run-integration-tests |
|
/run-integration-tests |
|
/rebuild |
|
/run-integration-tests |
Co-Authored-By: JaySon <jayson.hjs@gmail.com>
JaySon-Huang
approved these changes
Nov 11, 2019
There was a problem hiding this comment.
LGTM.
But mark that maybe we should find a way not to change the behavior for engine TxnMergeTree later with raft.disable_bg_flush turn on?
@flowbehappy please take a look.
|
LGTM |
flowbehappy
approved these changes
Nov 12, 2019
12 tasks
JaySon-Huang
added a commit
to JaySon-Huang/tiflash
that referenced
this pull request
Dec 3, 2024
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com> Co-authored-by: jinhelin <linjinhe33@gmail.com> Co-authored-by: JaySon <tshent@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that if we set
raft.disable_bg_flushto true, both storages of TxnMergeTree and DeltaMerge will be affected.