Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASH-659] Make Region Mapped To Only One Table #318

Merged
merged 12 commits into from
Nov 13, 2019
Merged

[FLASH-659] Make Region Mapped To Only One Table #318

merged 12 commits into from
Nov 13, 2019

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented Nov 11, 2019

  • Remove MaxSystemTableID.

  • Move RegionReadStatus from RegionTable to RegionException.

  • Optimize applySnapshot: extend range of region in RegionTable first, then try flush region data into ch first to avoid persisting huge snapshot.

  • Refactor RegionTable and make region only mapped to one table.

  • Optimize for raft cmd CompactLog.

@solotzg solotzg requested a review from innerr November 11, 2019 12:57
@solotzg
Copy link
Contributor Author

solotzg commented Nov 11, 2019

/run-integration-tests

Try to flush region data into ch while handling cmd CompactLog
@solotzg
Copy link
Contributor Author

solotzg commented Nov 12, 2019

I've moved RegionReadStatus into RegionException, PTAL @zanmato1984

@solotzg
Copy link
Contributor Author

solotzg commented Nov 12, 2019

/run-integration-tests

dbms/src/Storages/StorageMergeTree.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/PartitionStreams.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/Region.cpp Show resolved Hide resolved
dbms/src/Storages/Transaction/Region.h Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/Region.cpp Show resolved Hide resolved
dbms/src/Storages/Transaction/RegionRangeKeys.h Outdated Show resolved Hide resolved
dbms/src/Raft/RaftService.cpp Show resolved Hide resolved
dbms/src/Storages/Transaction/RegionTable.cpp Outdated Show resolved Hide resolved
dirty_it++;
}
else
dirty_it = dirty_regions.erase(dirty_it);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't buy this deletion unless you insist.

Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solotzg
Copy link
Contributor Author

solotzg commented Nov 13, 2019

/run-integration-tests

@solotzg solotzg merged commit 269806c into pingcap:master Nov 13, 2019
@solotzg solotzg deleted the FLASH-659 branch November 13, 2019 15:44
CalvinNeo added a commit to CalvinNeo/tiflash that referenced this pull request Nov 20, 2024
…cap#318)

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Nov 20, 2024
JaySon-Huang pushed a commit to JaySon-Huang/tiflash that referenced this pull request Dec 3, 2024
…cap#318)

Signed-off-by: Calvin Neo <calvinneo1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants