[FLASH-739] Add cluster manager service by poco timer #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solotzg
reviewed
Nov 28, 2019
solotzg
reviewed
Nov 28, 2019
| auto task_interval = conf.getInt(TASK_INTERVAL_KEY, 10) * SECOND; | ||
|
|
||
| if (!Poco::File(bin_path).exists()) | ||
| throw Exception("Cluster manager binary file does not exist: " + bin_path); |
There was a problem hiding this comment.
add error log here, application will exit without any info if is running as daemon.
use ErrorCodes::LOGICAL_ERROR
|
/run-integration-tests |
solotzg
reviewed
Nov 28, 2019
| { | ||
| const auto & conf = context.getConfigRef(); | ||
|
|
||
| auto bin_path = conf.getString(CLUSTER_MANAGER_PATH_KEY, ".") + Poco::Path::separator() + BIN_NAME; |
There was a problem hiding this comment.
In our mock test, flash_cluster_manager can not be found definitely, make it optional
ilovesoup
changed the title
solotzg
reviewed
Dec 3, 2019
| throw Exception("Cluster manager binary file does not exist: " + bin_path); | ||
|
|
||
| std::vector<std::string> args; | ||
| args.push_back(config_path); |
There was a problem hiding this comment.
latest format of args is: /pinary-path --config config_path
|
move to #331 , close it. |
This was referenced Jun 30, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a cluster manager service by Poco::Timer that runs cluster manager python script every refresh_interval seconds. At the meanwhile, cluster manager scripts should be changed to non-looping style. This will eliminate the need of supervise the script when deploy and user need not care about flash_cluster_manager.