Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASH-755] Fix rows not match after update #346

Merged
merged 3 commits into from
Dec 10, 2019

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Dec 10, 2019

While creating delta value space (DiskValueSpace::getValueSpace), we filter some chunks by read range.
But we not only need values to read, but also need all values to build DeltaTree.
This PR temporary disable chunk filter in DiskValueSpace::getValueSpace to make it right.

@JaySon-Huang JaySon-Huang merged commit 754db1f into pingcap:DeltaMergeEngine Dec 10, 2019
@JaySon-Huang JaySon-Huang deleted the debug-update branch December 10, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants