Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of xml config file for client command #356

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Remove use of xml config file for client command #356

merged 2 commits into from
Dec 16, 2019

Conversation

lidezhu
Copy link
Contributor

@lidezhu lidezhu commented Dec 16, 2019

No description provided.

@lidezhu lidezhu changed the title Make tiflash client command use toml config file Make tiflash client command use toml config file Dec 16, 2019
@lidezhu
Copy link
Contributor Author

lidezhu commented Dec 16, 2019

/run-integration-tests

solotzg
solotzg approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@solotzg solotzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lidezhu
Copy link
Contributor Author

lidezhu commented Dec 16, 2019

/run-integration-tests

1 similar comment
@lidezhu
Copy link
Contributor Author

lidezhu commented Dec 16, 2019

/run-integration-tests

@lidezhu lidezhu changed the title Make tiflash client command use toml config file Remove use of xml config file for client command Dec 16, 2019
@lidezhu lidezhu merged commit 5312adc into master Dec 16, 2019
@lidezhu lidezhu deleted the fix-client-config branch December 16, 2019 08:14
@CalvinNeo CalvinNeo mentioned this pull request Nov 7, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solotzg solotzg solotzg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lidezhu @solotzg