Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLASH-774] Refactor process about pre-decode/block-read to support fast codec #375

Merged
merged 29 commits into from
Jan 8, 2020
Merged

[FLASH-774] Refactor process about pre-decode/block-read to support fast codec #375

merged 29 commits into from
Jan 8, 2020

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented Dec 27, 2019

No description provided.

@solotzg solotzg requested a review from zanmato1984 December 27, 2019 07:32
@solotzg
Copy link
Contributor Author

solotzg commented Dec 27, 2019

/run-integration-tests

@solotzg solotzg requested a review from hanfei1991 December 27, 2019 09:32
@solotzg solotzg requested a review from lidezhu December 27, 2019 09:45
@solotzg
Copy link
Contributor Author

solotzg commented Dec 27, 2019

/run-integration-tests

@solotzg
Copy link
Contributor Author

solotzg commented Dec 27, 2019

https://internal.pingcap.net/jira/browse/FLASH-774

@solotzg solotzg changed the title [FLASH-774] Refactor process about pre-decode to support fast codec [DNM] [FLASH-774] Refactor process about pre-decode to support fast codec Dec 28, 2019
@solotzg
Merge remote-tracking branch 'pingcap/master' into FLASH-774
c49e89f 
# Conflicts:
#	dbms/src/Storages/Transaction/RegionBlockReader.cpp
#	dbms/src/Storages/Transaction/TiKVDecodedValue.h
@solotzg
fix compile
927b69c
@solotzg
test
31b6c20
@solotzg
update
79604c0 
only pre decode column in value
@solotzg solotzg changed the title [DNM] [FLASH-774] Refactor process about pre-decode to support fast codec [FLASH-774] Refactor process about pre-decode to support fast codec Dec 28, 2019
@solotzg
Copy link
Contributor Author

solotzg commented Dec 28, 2019

/run-integration-tests

zanmato1984
zanmato1984 reviewed Jan 2, 2020
View reviewed changes
dbms/src/Storages/Transaction/PredecodeTiKVValue.h Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/PredecodeTiKVValue.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/PredecodeTiKVValue.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/PredecodeTiKVValue.cpp Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/TiKVDecodedValue.h Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/TiKVDecodedValue.h Outdated Show resolved Hide resolved
@solotzg
Copy link
Contributor Author

solotzg commented Jan 3, 2020

@zanmato1984 PTAL

@zanmato1984
Copy link
Contributor

I'm OK with the implementation. However I'm still confused about some design point. I suggest we organize a group review to involve more audience.

@ilovesoup @innerr What do you guys think?

@ilovesoup
Copy link
Contributor

I'm OK with the implementation. However I'm still confused about some design point. I suggest we organize a group review to involve more audience.

@ilovesoup @innerr What do you guys think?

yeah. let's do it next Mondy.

@solotzg
Copy link
Contributor Author

solotzg commented Jan 4, 2020

/run-integration-tests

@solotzg
Copy link
Contributor Author

solotzg commented Jan 7, 2020

/run-integration-tests

zanmato1984
zanmato1984 reviewed Jan 7, 2020
View reviewed changes
dbms/src/Storages/Transaction/TiKVDecodedValue.h Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/TiKVDecodedValue.h Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/TiKVDecodedValue.h Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/TiKVDecodedValue.h Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/TiKVDecodedValue.h Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/TiKVDecodedValue.h Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/TiKVDecodedValue.h Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/TiKVDecodedValue.h Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/TiKVDecodedValue.h Outdated Show resolved Hide resolved
dbms/src/Storages/Transaction/TiKVValueExtra.h Outdated Show resolved Hide resolved
@solotzg
Copy link
Contributor Author

solotzg commented Jan 7, 2020

@zanmato1984 PTAL

@solotzg
Copy link
Contributor Author

solotzg commented Jan 8, 2020

/run-integration-tests

@solotzg solotzg changed the title [FLASH-774] Refactor process about pre-decode to support fast codec [FLASH-774] Refactor process about pre-decode/block-read to support fast codec Jan 8, 2020
@solotzg
Copy link
Contributor Author

solotzg commented Jan 8, 2020

/run-integration-tests

zanmato1984
zanmato1984 approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@zanmato1984 zanmato1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solotzg
Copy link
Contributor Author

solotzg commented Jan 8, 2020

/run-integration-tests

@solotzg solotzg merged commit 7894fe8 into pingcap:master Jan 8, 2020
@solotzg solotzg deleted the FLASH-774 branch January 8, 2020 06:40
@CalvinNeo CalvinNeo mentioned this pull request Jun 20, 2024
Merged
12 tasks
This was referenced Sep 4, 2024
Closed
Merged
@CalvinNeo CalvinNeo mentioned this pull request Nov 7, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@hanfei1991 hanfei1991 Awaiting requested review from hanfei1991

@lidezhu lidezhu Awaiting requested review from lidezhu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@solotzg @zanmato1984 @ilovesoup