Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLASH-223] Fix Process When UInt64 Is Handle #47

Merged
merged 6 commits into from
Apr 18, 2019
Merged

[FLASH-223] Fix Process When UInt64 Is Handle #47

merged 6 commits into from
Apr 18, 2019

Conversation

solotzg
Copy link
Contributor

@solotzg solotzg commented Apr 16, 2019 •
edited
Loading

  • Fix Bug: When PK handle is int64::max() or uint64::max(), tiflash can't select corresponding record.
  • Optimize MvccTMTSortedBlockInputStream: fetch version_column and del_column directly.
  • Optimize RangesFilterBlockInputStream, RangesFilterBlockInputStream...: If column is numeric, use function getUInt to get the value of n-th PK or TSO, casted to UInt64.
  • If PK is uint64, try to split the range of region into two, because the order of tikv key is not equal with the order of PK. For example, 2^63 is positive in uint64, but negative in int64. If PK is not uint64, cast to int64.
  • Fix bug in RegionBlockRead
  • Use HandleRange to present the range of a table in region.
  • fix bug: Region::doRemove should ignore operation about write/data cf.

@solotzg solotzg changed the title [DNM] [FLASH-223] Fix Process When UInt64 Is Handle [FLASH-223] Fix Process When UInt64 Is Handle Apr 17, 2019
@solotzg solotzg requested a review from innerr April 17, 2019 07:12
innerr
innerr previously approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@innerr innerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed all codes except DataStream and SelectExecutor, LGTM.
Please invite another one to review the codes I skipped.

@solotzg solotzg requested a review from lidezhu April 17, 2019 09:25
@solotzg
Copy link
Contributor Author

solotzg commented Apr 18, 2019

image

@solotzg
Copy link
Contributor Author

solotzg commented Apr 18, 2019

image

@solotzg
Copy link
Contributor Author

solotzg commented Apr 18, 2019

image

zhexuany
zhexuany approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@zhexuany zhexuany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@solotzg
Copy link
Contributor Author

solotzg commented Apr 18, 2019

/run-integration-tests

@solotzg solotzg merged commit 058cb1f into pingcap:master Apr 18, 2019
@solotzg solotzg removed the request for review from lidezhu April 18, 2019 09:32
@solotzg solotzg deleted the FLASH-223 branch April 18, 2019 09:45
@zanmato1984 zanmato1984 mentioned this pull request Apr 22, 2019
Closed
@CalvinNeo CalvinNeo mentioned this pull request Nov 7, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhexuany zhexuany zhexuany approved these changes

@innerr innerr innerr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@solotzg @innerr @zhexuany