APIV2HelpersImpl(ticdc): remove the impossible condition in APIV2HelpersImpl.verifyCreateChangefeedConfig() #11464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elpersImpl.verifyCreateChangefeedConfig()
ti-chi-bot
bot
added
first-time-contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
the
size/XS
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11464 +/- ##
================================================
+ Coverage 57.4564% 57.4712% +0.0148%
================================================
Files 849 850 +1
Lines 126313 126404 +91
================================================
+ Hits 72575 72646 +71
- Misses 48336 48350 +14
- Partials 5402 5408 +6 |
|
/retest |
wlwilliamx
deleted the
refactor/APIV2HelpersImpl.verifyCreateChangefeedConfig-impossible-condition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #11463
What is changed and how it works?
Removed the impossible condition in APIV2HelpersImpl.verifyCreateChangefeedConfig().
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note