-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
integration test(ticdc): Fix Tar Wildcard Handling in download-integration-test-binaries.sh #11513
integration test(ticdc): Fix Tar Wildcard Handling in download-integration-test-binaries.sh #11513
Conversation
…ion-test-binaries.sh
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #11513 +/- ##
================================================
+ Coverage 57.4511% 57.4887% +0.0376%
================================================
Files 851 851
Lines 126431 126463 +32
================================================
+ Hits 72636 72702 +66
+ Misses 48384 48361 -23
+ Partials 5411 5400 -11 |
/retest |
/check-issue-triage-complete |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongyunyan, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/test cdc-integration-kafka-test |
What problem does this PR solve?
Issue Number: close #11512
What is changed and how it works?
Summary:
This PR fixes an issue related to wildcard handling in the
scripts/download-integration-test-binaries.sh
script, which is used to download and extract required binaries for integration tests in TiCDC. The problem affects systems with certaintar
implementations where wildcard matching is not enabled by default, causing the extraction of PD binaries to fail and integration tests to break.Issue Explanation:
In the current implementation, the following command is used to extract the
pd-server.tar.gz
package:This command uses a wildcard pattern
'bin/*'
to match and extract all files within thebin
directory of the compressedpd-server.tar.gz
archive.However, not all versions of
tar
handle wildcard patterns by default. In particular:tar
: These versions do not enable wildcard support unless the--wildcards
option is explicitly specified.tar
: Newer versions of GNUtar
generally support wildcards by default, but it's not guaranteed across all environments.When the script is executed on systems where
tar
does not natively support wildcard patterns, the command fails to extract the necessary PD executables. As a result:third_bin
directory remains empty of PD-related binaries.Proposed Solution:
To resolve this issue, I have added the
--wildcards
option to thetar
command in the script, ensuring that wildcard matching works correctly across all versions oftar
. Here is the updated command:By explicitly adding the
--wildcards
option:tar
implementations.third_bin
directory, allowing the integration tests to run successfully.Steps Taken:
tar
command in thescripts/download-integration-test-binaries.sh
script to include the--wildcards
option.tar
and non-GNUtar
versions.Impact:
This fix ensures that the integration test binaries are reliably downloaded and extracted across different environments, preventing failures caused by missing PD executables. This improves the stability and portability of the TiCDC integration tests.
No other parts of the system are affected by this change, and no additional dependencies are introduced.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No
Do you need to update user documentation, design documentation or monitoring documentation?
No
Release note