Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

old value feature can't be turned off if changefeed has enabled it #1299

Closed
amyangfei opened this issue Jan 13, 2021 · 1 comment · Fixed by #1304
Closed

old value feature can't be turned off if changefeed has enabled it #1299

amyangfei opened this issue Jan 13, 2021 · 1 comment · Fixed by #1304
Assignees
Labels
area/ticdc Issues or PRs related to TiCDC. priority/P0 The issue has P0 priority. type/bug The issue is confirmed as a bug.
Milestone

Comments

@amyangfei
Copy link
Contributor

amyangfei commented Jan 13, 2021

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.

    1. create two changefeed with `enable-old-value=true`, and replicate with a same table
    2. pause one of the changefeed (changefeed-1)
    3. update changefeed-1, set `enable old value = false`
    4. resume changefeed-1, the output result from changefeed-1 still contain old-value column
    
  2. What did you expect to see?

    old-value feature can be turned off

  3. What did you see instead?

    old-value feature can't be turned off

  4. Versions of the cluster

    • Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

      v4.0.9
      
    • TiCDC version (execute cdc version):

      v4.0.9
      
  5. Others

  • We need to confirm when multiple changefeeds exist, whether changefeed with old-value enabled will affect changefeed with old-value turned off.

there is another way to reproduce the error:

    1. create a changefeed to listen table1 with `enable-old-value=true`
    2. create another changefeed to listen the same table1 with `enable-old-value=false`

we can see that all of changefeed will output the row changed event with old value

@amyangfei amyangfei added the type/bug The issue is confirmed as a bug. label Jan 13, 2021
@amyangfei amyangfei added this to the v4.0.11 milestone Jan 13, 2021
@amyangfei amyangfei added the priority/P0 The issue has P0 priority. label Jan 14, 2021
@amyangfei
Copy link
Contributor Author

TiKV fix in tikv/tikv#9515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. priority/P0 The issue has P0 priority. type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants