Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

errorutil,sink,syncer: add errorutil to handle ignorable error #3264

Merged
merged 7 commits into from
Nov 10, 2021
Merged

errorutil,sink,syncer: add errorutil to handle ignorable error #3264

merged 7 commits into from
Nov 10, 2021

Conversation

fatelei
Copy link
Contributor

@fatelei fatelei commented Nov 4, 2021 •
edited by Rustin170506
Loading

What problem does this PR solve?

#3242

What is changed and how it works?

Add errorutil package to handle ignorable errors

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 4, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Ehco1996
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 4, 2021
@CLAassistant
Copy link

CLAassistant commented Nov 4, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Nov 4, 2021
@ti-chi-bot
Copy link
Member

Welcome @fatelei!

It looks like this is your first PR to pingcap/ticdc 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/ticdc. 😃

@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 4, 2021
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 4, 2021
@lance6716
Copy link
Contributor

our CI says it requires a make fmt

rest lgtm

@amyangfei
Copy link
Contributor

/run-integration-tests

1 similar comment
@amyangfei
Copy link
Contributor

/run-integration-tests

@Rustin170506
Copy link
Member

/run-integration-tests

/run-integration-test

@Rustin170506
Copy link
Member

/run-integration-tests

@amyangfei We are now fully aligned with the test name (and with other repositories and dm rules) and I will add the ci command documentation to the repository as soon as possible.

@amyangfei
Copy link
Contributor

/run-integration-test

lance6716
lance6716 reviewed Nov 5, 2021
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

pkg/errorutil/ignore.go Show resolved Hide resolved
@fatelei
Copy link
Contributor Author

fatelei commented Nov 5, 2021

@lance6716 comment resolved

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 5, 2021
@lance6716
Copy link
Contributor

/run-integration-test

@lance6716
Copy link
Contributor

/run-dm-compatibility-test

@lance6716
Copy link
Contributor

Hi @fatelei , I checked the ddl_ reentrant test, it has two problems now:

lance6716
lance6716 requested changes Nov 5, 2021
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need pass CI

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 5, 2021
@fatelei
Copy link
Contributor Author

fatelei commented Nov 5, 2021

Hi @fatelei , I checked the ddl_ reentrant test, it has two problems now:

ok

@ti-chi-bot ti-chi-bot removed the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 5, 2021
@lance6716
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: fbab888

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 9, 2021
@Rustin170506 Rustin170506 changed the title feat: add errorutil to handle ignorable error errorutil,sink,syncer: add errorutil to handle ignorable error Nov 9, 2021
@Rustin170506 Rustin170506 added area/dm Issues or PRs related to DM. area/ticdc Issues or PRs related to TiCDC. labels Nov 9, 2021
@Rustin170506
Copy link
Member

Rustin170506 commented Nov 9, 2021 •
edited
Loading

/hold
check failed.

cc: @lance6716

@ti-chi-bot ti-chi-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Nov 9, 2021
@lance6716
Copy link
Contributor

lance6716 commented Nov 9, 2021 •
edited
Loading

/hold check failed.

cc: @lance6716

should be fixed by pingcap/ticdc@e540b72

when https://github.com/pingcap/ticdc/pull/3345 is merged we can merge master into this PR

@lance6716
Copy link
Contributor

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2021
@Ehco1996
Copy link
Contributor

/run-dm-integration-tests
/run-integration-test
/run-dm-compatibility-test
/run-kafka-integration-test

@ti-chi-bot
Copy link
Member

@fatelei: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lance6716
Copy link
Contributor

/run-dm-integration-tests
/run-integration-test

@ti-chi-bot ti-chi-bot merged commit e052c6a into pingcap:master Nov 10, 2021
@fatelei fatelei deleted the clean branch November 16, 2021 13:46
@lance6716 lance6716 added the needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. label Dec 13, 2021
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 13, 2021
Closed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3852.

lance6716 pushed a commit to lance6716/ticdc that referenced this pull request Dec 21, 2021
@fatelei @lance6716
errorutil,sink,syncer: add errorutil to handle ignorable error (pingc…
c2b8b29 
…ap#3264)
@lance6716 lance6716 mentioned this pull request Dec 21, 2021
Merged
ti-chi-bot pushed a commit that referenced this pull request Dec 21, 2021
@lance6716
errorutil,sink,syncer: add errorutil to handle ignorable error (#3264) (
707e24b 
#3995)
3AceShowHand pushed a commit to ti-chi-bot/tiflow that referenced this pull request Jan 13, 2022
@lance6716 @3AceShowHand
errorutil,sink,syncer: add errorutil to handle ignorable error (pingc…
d358c28 
…ap#3264) (pingcap#3995)
overvenus pushed a commit that referenced this pull request Jan 18, 2022
@ti-chi-bot @zhaoxinyu
@amyangfei @lance6716 @sdojjy @3AceShowHand
metrics(cdc): fix mq sink write row count metrics. (#4192) (#4323)
ae04769 
* fix the txn_batch_size metric inaccuracy bug when the sink target is MQ

* address comments

* add comments for exported functions

* fix the compiling problem

* workerpool: limit the rate to output deadlock warning (#3775) (#3795)

* tests(ticdc): set up the sync diff output directory correctly (#3725) (#3741)

* relay(dm): use binlog name comparison (#3710) (#3712)

* dm/load: fix concurrent call Loader.Status (#3459) (#3468)

* cdc/sorter: make unified sorter cgroup aware (#3436) (#3439)

* tz (ticdc): fix timezone error (#3887) (#3906)

* pkg,cdc: do not use log package (#3902) (#3940)

* *: rename repo from pingcap/ticdc to pingcap/tiflow (#3959)

* http_*: add log for http api and refine the err handle logic (#2997) (#3307)

* etcd_worker: batch etcd patch (#3277) (#3389)

* http_api (ticdc): check --cert-allowed-cn before add server common name (#3628) (#3882)

* kvclient(ticdc): fix kvclient takes too long time to recover (#3612) (#3663)

* owner: fix owner tick block http request (#3490) (#3530)

* dm/syncer: use downstream PK/UK to generate DML (#3168) (#3256)

* dep(dm): update go-mysql (#3914) (#3934)

* dm/syncer: multiple rows use downstream schema (#3308) (#3953)

* errorutil,sink,syncer: add errorutil to handle ignorable error (#3264) (#3995)

* dm/worker: don't exit when failed to read checkpoint in relay (#3345) (#4005)

* syncer(dm): use an early location to reset binlog and open safemode (#3860)

* ticdc/owner: Fix ddl special comment syntax error (#3845) (#3978)

* dm/scheduler: fix inconsistent of relay status (#3474) (#4009)

* owner,scheduler(cdc): fix nil pointer panic in owner scheduler (#2980) (#4007) (#4016)

* config(ticdc): Fix old value configuration check for maxwell protocol (#3747) (#3783)

* sink(ticdc): cherry pick sink bug fix to release 5.3 (#4083)

* master(dm): clean and treat invalid load task (#4004) (#4145)

* loader: fix wrong progress in query-status for loader (#4093) (#4143)

close #3252

* ticdc/processor: Fix backoff base delay misconfiguration (#3992) (#4028)

* dm: load table structure from dump files (#3295) (#4163)

* compactor: fix duplicate entry in safemode (#3432) (#3434) (#4088)

* kv(ticdc): reduce eventfeed rate limited log (#4072) (#4111)

close #4006

* metrics(ticdc): add resolved ts and add changefeed to dataflow (#4038) (#4104)

* This is an automated cherry-pick of #4192

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* retry(dm): align with tidb latest error message (#4172) (#4254)

close #4159, close #4246

* owner(ticdc): Add bootstrap and try to fix the meta information in it (#3838) (#3865)

* redolog: add a precleanup process when s3 enable (#3525) (#3878)

* ddl(dm): make skipped ddl pass `SplitDDL()` (#4176) (#4227)

close #4173

* cdc/sink: remove Initialize method from the sink interface (#3682) (#3765)

Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com>

* http_api (ticdc): fix http api 'get processor' panic. (#4117) (#4123)

close #3840

* sink (ticdc): fix a deadlock due to checkpointTs fall back in sinkNode (#4084) (#4099)

close #4055

* cdc/sink: adjust kafka initialization logic (#3192) (#4162)

* try fix conflicts.

* This is an automated cherry-pick of #4192

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>

* fix conflicts.

* fix conflicts.

Co-authored-by: zhaoxinyu <zhaoxinyu512@gmail.com>
Co-authored-by: amyangfei <yangfei@pingcap.com>
Co-authored-by: lance6716 <lance6716@gmail.com>
Co-authored-by: sdojjy <sdojjy@qq.com>
Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com>
Co-authored-by: 3AceShowHand <jinl1037@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 left review comments

@Ehco1996 Ehco1996 Ehco1996 approved these changes

@lance6716 lance6716 lance6716 approved these changes

@amyangfei amyangfei Awaiting requested review from amyangfei

Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. area/ticdc Issues or PRs related to TiCDC. contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-release-5.3 Should cherry pick this PR to release-5.3 branch. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fatelei @ti-chi-bot @CLAassistant @lance6716 @amyangfei @Rustin170506 @Ehco1996