-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config(ticdc): Fix old value configuration check for maxwell protocol (#3747) #3779
config(ticdc): Fix old value configuration check for maxwell protocol (#3747) #3779
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
22fde10
to
63fe120
Compare
Codecov Report
@@ Coverage Diff @@
## release-4.0 #3779 +/- ##
===================================================
+ Coverage 53.7661% 57.1615% +3.3954%
===================================================
Files 153 170 +17
Lines 15958 19849 +3891
===================================================
+ Hits 8580 11346 +2766
- Misses 6475 7440 +965
- Partials 903 1063 +160 |
Manual testing:
enable-old-value=false
[sink]
protocol = "maxwell"
canal-json:
|
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 63fe120
|
This is an automated cherry-pick of #3747 and #3983
What problem does this PR solve?
close https://github.com/pingcap/ticdc/issues/3676
What is changed and how it works?
Check List
Tests
Unit test
Manual test(https://github.com/pingcap/ticdc/pull/3747#issuecomment-986629511)
Code changes
Has exported function/method change
Has exported variable/fields change
Side effects
None
Related changes
Release note