Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config(ticdc): Fix old value configuration check for maxwell protocol (#3747) #3779

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Dec 8, 2021

This is an automated cherry-pick of #3747 and #3983

What problem does this PR solve?

close https://github.com/pingcap/ticdc/issues/3676

What is changed and how it works?

  • add validate funcs
  • complete protocol when create changefeed
  • add tests

Check List

Tests

Side effects

None

Related changes

  • Need to cherry-pick to the release branch

Release note

Fix the problem that old value is not forced on automatically in `canal-json` and `maxwell` protocols

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 8, 2021
@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved area/ticdc Issues or PRs related to TiCDC. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. labels Dec 8, 2021
@ti-chi-bot ti-chi-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 8, 2021
@ti-chi-bot ti-chi-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 24, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3779 (63fe120) into release-4.0 (753073a) will increase coverage by 3.3954%.
The diff coverage is 67.1043%.

@@                 Coverage Diff                 @@
##           release-4.0      #3779        +/-   ##
===================================================
+ Coverage      53.7661%   57.1615%   +3.3954%     
===================================================
  Files              153        170        +17     
  Lines            15958      19849      +3891     
===================================================
+ Hits              8580      11346      +2766     
- Misses            6475       7440       +965     
- Partials           903       1063       +160     

@Rustin170506
Copy link
Member

Rustin170506 commented Dec 24, 2021

Manual testing:

  1. start tidb cluster
  2. start cdc server
  3. add new changefeed config file
enable-old-value=false

[sink]

protocol = "maxwell"
  1. run: ./cdc cli changefeed create --pd http://127.0.0.1:2379 --sink-uri kafka://127.0.0.1:9092/ticdc-test --config=changefeed.toml
  2. output:
➜  bin git:(master) ✗ ./cdc cli changefeed create --pd http://127.0.0.1:2379 --sink-uri "kafka://127.0.0.1:61536/ticdc-test" --config=changefeed.toml
[2021/12/24 15:02:51.728 +08:00] [WARN] [client_changefeed.go:314] ["Attempting to replicate without old value enabled. CDC will enable old value and continue."] [protocol=maxwell]

canal-json:

[2021/12/24 15:04:40.200 +08:00] [WARN] [client_changefeed.go:314] ["Attempting to replicate without old value enabled. CDC will enable old value and continue."] [protocol=canal-json]

@Rustin170506
Copy link
Member

/run-all-tests

@Rustin170506
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 63fe120

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 24, 2021
@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 24, 2021
@ti-chi-bot ti-chi-bot merged commit 5a6fc5c into pingcap:release-4.0 Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants