-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics(cdc): fix mq sink write row count metrics. (#4192) #4323
metrics(cdc): fix mq sink write row count metrics. (#4192) #4323
Conversation
) (pingcap#3765) Co-authored-by: Ling Jin <7138436+3AceShowHand@users.noreply.github.com>
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team. To merge this cherry pick, it must first be approved by the collaborators. AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
@@ Coverage Diff @@
## release-5.3 #4323 +/- ##
================================================
Coverage ? 55.1040%
================================================
Files ? 218
Lines ? 23305
Branches ? 0
================================================
Hits ? 12842
Misses ? 9161
Partials ? 1302 |
/run-all-tests |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 7ee6dba
|
This is an automated cherry-pick of #4192
What problem does this PR solve?
Issue Number: close #3431
What is changed and how it works?
For Canal-JSON,
sink-write-rows-count
is not correctly recorded, this PR only fixes Canal-JSON at the moment.Maybe we should take further investigation into sink related metrics, and tries to unify them together.
Check List
Tests
Code changes
Side effects
Related changes
Release note