Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls(dm): fix the error when only ssl-ca is configured #7962

Merged
merged 3 commits into from
Dec 23, 2022
Merged

tls(dm): fix the error when only ssl-ca is configured #7962

merged 3 commits into from
Dec 23, 2022

Conversation

liumengya94
Copy link
Contributor

@liumengya94 liumengya94 commented Dec 22, 2022 •
edited
Loading

What problem does this PR solve?

Issue Number: close #7941

What is changed and how it works?

don't dump if user didn't specify some ssl-xxx

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?

No

Do you need to update user documentation, design documentation or monitoring documentation?

No

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 22, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • D3Hunter
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 22, 2022
@liumengya94
Copy link
Contributor Author

/run-dm-integration-test

@liumengya94
Copy link
Contributor Author

/run-all-tests

@liumengya94
Copy link
Contributor Author

/cc @D3Hunter

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 23, 2022
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Dec 23, 2022
@D3Hunter D3Hunter added affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. labels Dec 23, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 23, 2022
@lance6716
Copy link
Contributor

release-6.5 should also be fixed

@D3Hunter
Copy link
Contributor

release-6.5 should also be fixed

after 6.3, we're passing SSLCaBytes to lightning, no such problem

@D3Hunter
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9acb5e4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 23, 2022
@ti-chi-bot ti-chi-bot merged commit ce45409 into pingcap:release-6.1 Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@D3Hunter D3Hunter D3Hunter approved these changes

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
affects-5.4 This bug affects the 5.4.x(LTS) versions. affects-6.1 This bug affects the 6.1.x(LTS) versions. cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liumengya94 @ti-chi-bot @lance6716 @D3Hunter @VelocityLight