Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review input validation for schema #39

Closed
patrickcping opened this issue Feb 7, 2023 · 1 comment
Closed

Review input validation for schema #39

patrickcping opened this issue Feb 7, 2023 · 1 comment
Labels
size/medium Medium size change (e.g. enhancing the logic of an existing resource or datasource) status/needs-triage The issue/PR needs initial triage type/enhancement New feature or request

Comments

@patrickcping
Copy link
Contributor

Ideally we'll have input validation on fields that might need it because of API restrictions.

The following example is the PingOne environment ID, which will use a pre-defined validator

Example (without validation):

"environment_id": {
Type: schema.TypeString,
Required: true,
Description: "PingOne environment id",
},

Example (with validation)
https://github.com/pingidentity/terraform-provider-pingone/blob/a2e6d79e38d7305040f9a875fca0ee259d0e76bb/internal/service/sso/resource_group.go#L34-L40

@patrickcping patrickcping added type/enhancement New feature or request size/medium Medium size change (e.g. enhancing the logic of an existing resource or datasource) status/needs-triage The issue/PR needs initial triage labels Dec 29, 2023
@patrickcping patrickcping modified the milestones: v0.3.0, v0.4.0 Jan 8, 2024
@patrickcping patrickcping modified the milestones: v0.4.0, v0.4.1, v0.4.2 Aug 15, 2024
@patrickcping
Copy link
Contributor Author

Deferred to activity that merges DaVinci capability to the PingOne Terraform provider

@patrickcping patrickcping closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2024
@patrickcping patrickcping removed this from the v0.4.2 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/medium Medium size change (e.g. enhancing the logic of an existing resource or datasource) status/needs-triage The issue/PR needs initial triage type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant