Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/pingone_schema_attribute: Add data loss protection validation #879

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

patrickcping
Copy link
Collaborator

@patrickcping patrickcping commented Jul 5, 2024

Change Description

  • Bug resource/pingone_schema_attribute: Fixed issue where schema attributes have the required field set to the incorrect boolean value.
  • Enhancement resource/pingone_schema_attribute: Added data protection validation to mitigate accidental deletion of custom user data.

Required SDK Upgrades

N/a

Testing Shell Command

TF_ACC=1 go test -v -timeout 1200s -run ^TestAccSchemaAttribute_ github.com/pingidentity/terraform-provider-pingone/internal/service/sso

Testing Results

Expand Results
=== RUN   TestAccSchemaAttribute_RemovalDrift
=== PAUSE TestAccSchemaAttribute_RemovalDrift
=== RUN   TestAccSchemaAttribute_NewEnv
=== PAUSE TestAccSchemaAttribute_NewEnv
=== RUN   TestAccSchemaAttribute_String
=== PAUSE TestAccSchemaAttribute_String
=== RUN   TestAccSchemaAttribute_StringEnumeratedValues
=== PAUSE TestAccSchemaAttribute_StringEnumeratedValues
=== RUN   TestAccSchemaAttribute_StringRegexValidation
=== PAUSE TestAccSchemaAttribute_StringRegexValidation
=== RUN   TestAccSchemaAttribute_StringParameterCombinations
=== PAUSE TestAccSchemaAttribute_StringParameterCombinations
=== RUN   TestAccSchemaAttribute_JSON
=== PAUSE TestAccSchemaAttribute_JSON
=== RUN   TestAccSchemaAttribute_JSONInvalidAttrs
=== PAUSE TestAccSchemaAttribute_JSONInvalidAttrs
=== RUN   TestAccSchemaAttribute_JSONParameterCombinations
=== PAUSE TestAccSchemaAttribute_JSONParameterCombinations
=== RUN   TestAccSchemaAttribute_BadParameters
=== PAUSE TestAccSchemaAttribute_BadParameters
=== RUN   TestAccSchemaAttribute_DLP
=== PAUSE TestAccSchemaAttribute_DLP
=== CONT  TestAccSchemaAttribute_RemovalDrift
=== CONT  TestAccSchemaAttribute_JSON
=== CONT  TestAccSchemaAttribute_BadParameters
=== CONT  TestAccSchemaAttribute_DLP
=== CONT  TestAccSchemaAttribute_JSONParameterCombinations
=== CONT  TestAccSchemaAttribute_JSONInvalidAttrs
=== CONT  TestAccSchemaAttribute_StringRegexValidation
=== CONT  TestAccSchemaAttribute_StringParameterCombinations
=== CONT  TestAccSchemaAttribute_NewEnv
=== CONT  TestAccSchemaAttribute_String
=== CONT  TestAccSchemaAttribute_StringEnumeratedValues
--- PASS: TestAccSchemaAttribute_JSONInvalidAttrs (2.14s)
--- PASS: TestAccSchemaAttribute_BadParameters (10.87s)
--- PASS: TestAccSchemaAttribute_StringEnumeratedValues (13.69s)
--- PASS: TestAccSchemaAttribute_JSONParameterCombinations (13.92s)
--- PASS: TestAccSchemaAttribute_DLP (24.28s)
--- PASS: TestAccSchemaAttribute_StringParameterCombinations (25.07s)
--- PASS: TestAccSchemaAttribute_JSON (26.94s)
--- PASS: TestAccSchemaAttribute_String (27.01s)
--- PASS: TestAccSchemaAttribute_StringRegexValidation (27.21s)
--- PASS: TestAccSchemaAttribute_NewEnv (41.63s)
--- PASS: TestAccSchemaAttribute_RemovalDrift (48.52s)
PASS
ok      github.com/pingidentity/terraform-provider-pingone/internal/service/sso 50.255s

@patrickcping patrickcping added type/bug Something isn't working type/enhancement New feature or request service/sso PingOne SSO labels Jul 5, 2024
@patrickcping patrickcping added this to the v1.0.0-rc2 milestone Jul 5, 2024
@patrickcping patrickcping self-assigned this Jul 5, 2024
@patrickcping patrickcping marked this pull request as ready for review July 5, 2024 11:55
@patrickcping patrickcping requested a review from a team as a code owner July 5, 2024 11:55
@patrickcping patrickcping merged commit 3c4f8d5 into main Jul 5, 2024
13 checks passed
@patrickcping patrickcping deleted the schema-attribute-data-loss-protection-202407 branch July 5, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/sso PingOne SSO type/bug Something isn't working type/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant