Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/pingone_agreement_localization_revision: Add buffer time to the revision effective date to avoid blocking error #883

Conversation

patrickcping
Copy link
Collaborator

@patrickcping patrickcping commented Jul 5, 2024

Change Description

  • resource/pingone_agreement_localization_revision: Add buffer time to the revision effective date to avoid blocking error
  • Bug Fixed intermittent "The revision can not take effect in the past" error when leaving effective_at blank.

Required SDK Upgrades

N/a

Testing Shell Command

TF_ACC=1 go test -v -timeout 1200s -run ^TestAccAgreementLocalizationRevision_ github.com/pingidentity/terraform-provider-pingone/internal/service/base

Testing Results

Expand Results
=== RUN   TestAccAgreementLocalizationRevision_RemovalDrift
=== PAUSE TestAccAgreementLocalizationRevision_RemovalDrift
=== RUN   TestAccAgreementLocalizationRevision_Full
=== PAUSE TestAccAgreementLocalizationRevision_Full
=== RUN   TestAccAgreementLocalizationRevision_BadParameters
=== PAUSE TestAccAgreementLocalizationRevision_BadParameters
=== CONT  TestAccAgreementLocalizationRevision_RemovalDrift
=== CONT  TestAccAgreementLocalizationRevision_BadParameters
=== CONT  TestAccAgreementLocalizationRevision_Full
--- PASS: TestAccAgreementLocalizationRevision_BadParameters (42.70s)
--- PASS: TestAccAgreementLocalizationRevision_RemovalDrift (55.67s)
--- PASS: TestAccAgreementLocalizationRevision_Full (136.15s)
PASS
ok      github.com/pingidentity/terraform-provider-pingone/internal/service/base        137.757s

…o the revision effective date to avoid blocking error
@patrickcping patrickcping added type/bug Something isn't working service/base PingOne Platform labels Jul 5, 2024
@patrickcping patrickcping added this to the v1.0.0-rc2 milestone Jul 5, 2024
@patrickcping patrickcping self-assigned this Jul 5, 2024
@patrickcping patrickcping marked this pull request as ready for review July 5, 2024 16:29
@patrickcping patrickcping requested a review from a team as a code owner July 5, 2024 16:29
@patrickcping patrickcping merged commit 71e49cb into main Jul 5, 2024
14 checks passed
@patrickcping patrickcping deleted the add-buffer-time-to-agreement-localisation-revision-effective-date-202407 branch July 5, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/base PingOne Platform type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant