Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mfa device policy resource - fido bug fix #940

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

wesleymccollam
Copy link

@wesleymccollam wesleymccollam commented Nov 19, 2024

Change Description

Resolves pingone_mfa_device_policy resource unexpected new value after terraform apply error:

│ Error: Provider produced inconsistent result after apply
│ 
│ When applying changes to pingone_mfa_device_policy.my_awesome_mfa_policy_with_mobile, provider "provider[\"registry.terraform.io/pingidentity/pingone\"]" produced an unexpected new value: .fido2: was null, but now cty.ObjectVal(map[string]cty.Value{"enabled":cty.False, "fido2_policy_id":cty.NullVal(cty.String), "pairing_disabled":cty.NullVal(cty.Bool),
│ "prompt_for_nickname_on_pairing":cty.NullVal(cty.Bool)}).
│ 
│ This is a bug in the provider, which should be reported in the provider's own issue tracker.

Required SDK Upgrades

  • N/A

Testing Shell Command

TF_ACC=1 go test -v -timeout 240s -run ^TestAccMFADevicePolicy_FIDO2_ [github.com/pingidentity/terraform-provider-pingone/internal/service/mfa](http://github.com/pingidentity/terraform-provider-pingone/internal/service/mfa)

Testing Results

Expand Results
=== RUN   TestAccMFADevicePolicy_FIDO2_Full
=== PAUSE TestAccMFADevicePolicy_FIDO2_Full
=== RUN   TestAccMFADevicePolicy_FIDO2_Minimal
=== PAUSE TestAccMFADevicePolicy_FIDO2_Minimal
=== RUN   TestAccMFADevicePolicy_FIDO2_Change
=== PAUSE TestAccMFADevicePolicy_FIDO2_Change
=== RUN   TestAccMFADevicePolicy_FIDO2_Disabled
=== PAUSE TestAccMFADevicePolicy_FIDO2_Disabled
=== CONT  TestAccMFADevicePolicy_FIDO2_Full
=== CONT  TestAccMFADevicePolicy_FIDO2_Change
=== CONT  TestAccMFADevicePolicy_FIDO2_Minimal
=== CONT  TestAccMFADevicePolicy_FIDO2_Disabled
--- PASS: TestAccMFADevicePolicy_FIDO2_Minimal (3.87s)
--- PASS: TestAccMFADevicePolicy_FIDO2_Full (4.83s)
--- PASS: TestAccMFADevicePolicy_FIDO2_Disabled (8.77s)
--- PASS: TestAccMFADevicePolicy_FIDO2_Change (9.06s)
PASS
ok  	github.com/pingidentity/terraform-provider-pingone/internal/service/mfa	9.991s

@wesleymccollam wesleymccollam requested a review from a team as a code owner November 19, 2024 15:53
@patrickcping
Copy link
Collaborator

@wesleymccollam Would it be possible to use the PR template, so the testing outputs are logged against the PR?

Copy link
Collaborator

@patrickcping patrickcping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -1580,6 +1646,36 @@ resource "pingone_mfa_device_policy" "%[3]s" {
}`, acctest.MinimalSandboxEnvironment(environmentName, licenseID), environmentName, resourceName, name)
}

func testAccMFADevicePolicyConfigNoFido_NewEnv(environmentName, licenseID, resourceName, name string) string {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it's not used - good to remove?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants