Caller test failure on CITGM

[mcollina]

Pino is failing on CITGM in RHEL and Ubuntu systems

https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2880/nodes=rhel8-s390x/testReport/junit/(root)/citgm/pino_v7_8_1/
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2880/nodes=rhel8-x64/testReport/junit/(root)/citgm/pino_v7_8_1/
https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2880/nodes=ubuntu1804-64/testReport/junit/(root)/citgm/pino_v7_8_1/

# Subtest: when using a custom transport where all files in stacktrace are in the node_modules, the first file inside node_modules should be used
         not ok 1 - should match pattern provided
           ---
           diff: |
             --- expected
             +++ actual
             @@ -1,1 +1,1 @@
             -/done!/
             +""
           pattern: !re /done!/
           at:
             line: 52
             column: 5
             file: test/transport/caller.test.js
             type: Test
           stack: |
             Test.<anonymous> (test/transport/caller.test.js:52:5)
           source: |2
           
               t.match(actual, /done!/)
             ----^
             })
           ...
         
         1..1
         # failed 1 test
     not ok 3 - when using a custom transport where all files in stacktrace are in the node_modules, the first file inside node_modules should be used # time=618.84ms

However that test passes 100% of the time locally and on our CI. I think there is a bug lurking somewhere.

@mhdawson @targos could you replicate this problem on your machines (a citgm pino would do)? Do you think it would be possible to get access to one of those systems so that I can diagnose the problem?

[richardlau]

@mhdawson @targos could you replicate this problem on your machines (a citgm pino would do)? Do you think it would be possible to get access to one of those systems so that I can diagnose the problem?

@mcollina I've put your ssh keys onto test-ibm-rhel8-x64-3. You should be able to log in as root@ip address from our inventory. The CI jobs, e.g. citgm, run as the iojs user -- (sudo -s su - iojs once you're logged in). /home/iojs/build/workspace/citgm-smoker/smoker still contains the built node binaries from https://ci.nodejs.org/job/citgm-smoker/2880/nodes=rhel8-x64/.

I've also marked the system offline in Jenkins so there won't be interference from further CI runs. Please let me know when you're done with it so I can put it back.

[mcollina]

@richardlau @targos I have been trying to reproduce in that machine by running the test directly and I couldn't. The mistery keeps being there. How long can I keep the machine?

[richardlau]

@mcollina No rush for now, we have three other rhel8-x64 instances in use.

[mcollina]

@richardlau have you got any suggestion to debug this? I've tried several times and the suite is always passing.

[richardlau]

Have you tried running the test through citgm? Citgm also runs stuff in parallel -- perhaps the issue is sensitive to load?

[mcollina]

I did run

citgm-all -J --nodedir=/home/iojs/build/workspace/citgm-smoker/node -v warn -x /home/iojs/build/workspace/citgm-smoker/smoker/report.xml -q error > out

and the results came out green for pino.

I'm now trying running the test standalone until tomorrow morning to see if it crashes.

[richardlau]

Best of luck! The citgm job does pass --tmpDir /home/iojs/tmp/citgm_tmp to citgm to redirect the temporary directory, but otherwise that looks like how the job invokes citgm.

[mcollina]

I've opened a PR to fix this! You can reintegrate the instance back into the fold or leave it there until after we have released the new version of pino and tested on CITGM.

[mcollina]

Fresh CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2887

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.