Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors properly #9

Open
pinpox opened this issue Dec 8, 2018 · 1 comment
Open

Handle errors properly #9

pinpox opened this issue Dec 8, 2018 · 1 comment
Labels
enhancement New feature or request
Milestone
First stable version

Comments

@pinpox
Copy link
Owner

pinpox commented Dec 8, 2018

We should not always just panic
@pinpox pinpox added enhancement New feature or request and removed enhancement New feature or request labels Dec 8, 2018
@pinpox pinpox added this to the First stable version milestone Dec 8, 2018
@lhanson
Copy link
Contributor

lhanson commented Nov 27, 2019

For example, when misspelling the enabled property value as "ture" instead of "true", I get a stack trace:

panic: yaml: unmarshal errors:
  line 209: cannot unmarshal !!str `ture` into bool

goroutine 1 [running]:
main.check(...)
	/home/ldh/.local/lib/go/src/github.com/binaryplease/base16-universal-manager/main.go:144
main.NewConfig(0xc00001e300, 0x36, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/home/ldh/.local/lib/go/src/github.com/binaryplease/base16-universal-manager/config.go:48 +0x3f7
main.main()
	/home/ldh/.local/lib/go/src/github.com/binaryplease/base16-universal-manager/main.go:35 +0x78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
First stable version
Development

No branches or pull requests
2 participants
@lhanson @pinpox