NoWildcardImportsRule: don't report it if asterisk with backticks (#800)

pinterest · Jun 27, 2020 · bac44ab · bac44ab
1 parent c7bdae0
commit bac44ab
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/...t-standard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/NoWildcardImportsRule.kt b/...t-standard/src/main/kotlin/com/pinterest/ktlint/ruleset/standard/NoWildcardImportsRule.kt
@@ -14,8 +14,8 @@ class NoWildcardImportsRule : Rule("no-wildcard-imports") {
     ) {
         if (node.elementType == IMPORT_DIRECTIVE) {
             val importDirective = node.psi as KtImportDirective
-            val path = importDirective.importPath?.pathStr
-            if (path != null && !path.startsWith("kotlinx.android.synthetic") && path.contains('*')) {
+            val path = importDirective.importPath
+            if (path != null && path.isAllUnder && !path.pathStr.startsWith("kotlinx.android.synthetic")) {
                 emit(node.startOffset, "Wildcard import", false)
             }
         }

diff --git a/...andard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/NoWildcardImportsRuleTest.kt b/...andard/src/test/kotlin/com/pinterest/ktlint/ruleset/standard/NoWildcardImportsRuleTest.kt
@@ -16,6 +16,7 @@ class NoWildcardImportsRuleTest {
                 import a.b.c.*
                 import a.b
                 import kotlinx.android.synthetic.main.layout_name.*
+                import foo.bar.`**`
                 """.trimIndent()
             )
         ).isEqualTo(